Bug 288410 - Install filter support in feature.xml
Summary: Install filter support in feature.xml
Status: CLOSED WONTFIX
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks: 114546
  Show dependency tree
 
Reported: 2009-09-02 17:22 EDT by John Arthorne CLA
Modified: 2019-09-09 02:26 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2009-09-02 17:22:15 EDT 
P2 supports the notion of filters on dependencies that are matched against properties in the p2 profile. This is a generalization of the os/ws/arch filters that existed in the past in feature.xml. We should consider adding support for such an attribute to be specified in feature.xml, so that additional filters could be defined. For example this could be used to flag bundles or included features as "documentation" or "source" so that the system could be configured to *not* install documentation/source if so desired. See related discussion in bug 114546.

I imagine this would look something like this:

   <plugin
         id="org.eclipse.platform.doc.user"
         download-size="0"
         install-size="0"
         version="0.0.0"
         unpack="false"
         install-filter="(userdoc=true)"  --> new filter attribute
         />

The p2 publisher would then convert this to a required capability filter on the IU. Support for interpreting the IU filters already exists in the p2 runtime, so this looks like a small change to support the attribute in feature.xml editor, and a small publisher change to translate the value.
Comment 1 Curtis Windatt CLA 2009-09-02 17:27:24 EDT 
Worth considering.
Comment 2 John Arthorne CLA 2009-09-02 17:28:42 EDT 
I suspect this could be done today via p2.inf but the syntax for representing a filter on a given member of a feature is likely very complex.
Comment 3 Chris Aniszczyk CLA 2009-09-03 11:36:42 EDT 
Who owns the feature.xml format?
Comment 4 John Arthorne CLA 2009-10-29 15:06:28 EDT 
(In reply to comment #3)
> Who owns the feature.xml format?

We do ;)

It's historically an Update Manager construct, but it lives on in the p2 world (at least so far).
Comment 5 Eclipse Webmaster CLA 2019-09-06 15:29:51 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 6 Julian Honnen CLA 2019-09-09 02:26:18 EDT 
Please remove the stalebug flag, if this issue is still relevant and can be reproduced on the latest release.