Bug 288121 - [perfs] Comments applied for performance tests are obsolete
Summary: [perfs] Comments applied for performance tests are obsolete
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.6 M2   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 288122
  Show dependency tree
 
Reported: 2009-08-31 09:49 EDT by Frederic Fusier CLA
Modified: 2010-05-21 06:59 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Fusier CLA 2009-08-31 09:49:25 EDT 
Looking at code in HEAD today, I can see that RenameMethodWithOverloadPerfTests test suite has a method explainDegradation() method referencing the Performance.setComment method with the following comment:
"The degradation is a consequence of fixing bug 250454 in JDT Core."

As bug 250454 was fixed in 3.5 this comment should be removed for 3.6 performance tests, hence update the 3 methods using it (i.e. calling explainDegradation()).
Comment 1 Dani Megert CLA 2009-08-31 09:55:42 EDT 
Taking that bug as I added the comments.
Comment 2 Dani Megert CLA 2009-08-31 10:56:03 EDT 
Fixed in HEAD.
Available in builds > N2090830-2000.