Description Simone Gianni 2009-08-30 08:14:43 EDT

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.5) Gecko/2009010218 Gentoo Firefox/3.0.5
Build Identifier: 20090619-0625

BcelClassWeaver has a method checkUnusedDeclareAtTypes that should check if a declare @xxx goes unused. This method reports error in some situations where the declare is perfectly legal and applied. For example :

declare @method: public String MyClass+.a*(..) : @Deprecated;

Will give error if there is a method named "aSomething" in a subclass of MyClass.

Looking at the code, it seems like it avoids performing this check unless the declare has an exact pattern. In fact it checks :
- If the declaration uses an ExactTypePattern
AND
- If the delcaration is NOT any
- OR if the declaration is on a constructor

 MyClass+.a*(..), that should not be tested, is in fact tested because :
- It is not an exact type (the typePattern is null) which is right
- It is not an ANY ("a*" is not any, "*" would be any)
- It is not a constructor

I think a "isWithWildcard" is missing, as an alternative to isAny, that should return true if starCount > 0, and should be used in this check.

Changing the type pattern in a way that eludes the check makes the problem go away, for example :

public String org.tests.M*Class.a*(..) // declA.getSignaturePattern().getDeclaringType() instanceof ExactTypePattern becomes false

public String MyClass.*(..) // declA.getSignaturePattern().getName().isAny() becomes true

Reproducible: Always

Steps to Reproduce:
1. Unzip the given test project
2. ajc or ltw
3. Look at the error "The method org.tests.MyClass+a*(..) does not exist".



Since annotation introduction is gaining quite an important role for AspectJ, I feel like this is a major bug.