Bug 287659 - Various patches to source code
Summary: Various patches to source code
Status: NEW
Alias: None
Product: Babel
Classification: Technology
Component: Plugins (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows NT
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Nigel Westbury CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-26 03:42 EDT by Srgjan Srepfler CLA
Modified: 2024-04-03 07:37 EDT (History)
2 users (show)

See Also:


Attachments
patch (8.26 KB, patch)
2009-08-26 03:44 EDT, Srgjan Srepfler CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Srgjan Srepfler CLA 2009-08-26 03:42:52 EDT
Build ID: I20090611-1540

Steps To Reproduce:
Ran FindBugs on source code, found some bugs, and started fixing:
1. AbstractMessageModel, use Long.valueOf instead of new Long
2. created hashCode for Message using the eclipse source generation on the properties used in the equals method.
3. marked the property PropertyChangeListener messageListener in MessagesBundle as transient and modified toString to use StringBuilder
4. marked the property IMessagesBundleListener messagesBundleListener in MessagesBundleGroup as transient and overloaded hashCode() on the property used in equals.
5. marked IMessagesBundleGroupStrategy as Serializable
6. marked IMessagesResource as Serializable
7. Generated hashCode() of KeyTreeNode on properties used in the equals method using the eclipse source generator wizard.

More information:
Comment 1 Srgjan Srepfler CLA 2009-08-26 03:44:20 EDT
Created attachment 145634 [details]
patch
Comment 2 Srgjan Srepfler CLA 2009-08-26 03:56:51 EDT
The criteria I've used on the Serializable patches, if the objects were listerners I've marked the fields as transient, if normal clases I've marked classes as Serializable, perhaps all should be marked as Serializable, I don't have the experience with eclipse and how it deals with these things.
Comment 3 Eclipse Genie CLA 2014-05-21 19:47:10 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 4 Eclipse Genie CLA 2016-05-11 10:05:10 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 5 Eclipse Genie CLA 2018-05-02 05:17:19 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 6 Srgjan Srepfler CLA 2018-05-02 14:44:55 EDT
Does anyone still work on this?
Comment 7 Eclipse Genie CLA 2020-04-22 03:44:58 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 8 Eclipse Genie CLA 2022-04-13 04:51:46 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 9 Eclipse Genie CLA 2024-04-03 07:37:51 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.