Description Ramnivas Laddad 2009-08-25 14:10:39 EDT

In a pointcut expression, the relative order of the access specification to annotations should not matter. Currently, pointcut matches if annotation expression appears only before the access specification. Since in Java the relative ordering doesn't matter, it shouldn't matter in AspectJ either.

Here is a test program that illustrates the problem (uses method annotations, but the problem exists for all other patterns).

package test;

import org.junit.Assert;
import org.junit.Test;

public class AnnotationModifierOrderingBug {
    @Test
    public void orderingOfAccessAndAnnotationDoesntMatter() {
        MyAnnotatedClass obj = new MyAnnotatedClass();
        obj.aMethod();
        Assert.assertEquals(1, MyAspect.aspectOf().annotBeforeAccess);
        Assert.assertEquals(1, MyAspect.aspectOf().accessBeforeAnnot);
    }
    
    static @interface MyAnnotation {
    }

    static class MyAnnotatedClass {
        @MyAnnotation
        public void aMethod() {
        }
    }

    static aspect MyAspect {
        private int accessBeforeAnnot;
        private int annotBeforeAccess;

        before() : execution(public @MyAnnotation * *(..)) {
            accessBeforeAnnot++;
        }

        before() : execution(@MyAnnotation public * *(..)) {
            annotBeforeAccess++;
        }
    }
}