Bug 286135 - [publisher] ProductPublisherApplication should support feature and plugin version advices as the corresponding ant task does
Summary: [publisher] ProductPublisherApplication should support feature and plugin ver...
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.6 M7   Edit
Assignee: Ian Bull CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2009-08-10 11:39 EDT by Jan Lohre CLA
Modified: 2010-05-25 17:09 EDT (History)
5 users (show)

See Also:
jeffmcaffer: pmc_approved+

Attachments
proposed patch (1.81 KB, patch)
2009-08-10 12:07 EDT, Jan Lohre CLA 		tjwatson: iplog+
Details | Diff
updated patch (1.75 KB, patch)
2010-04-16 16:26 EDT, Ian Bull CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Lohre CLA 2009-08-10 11:39:35 EDT 
The ant task ProductPublisherTask supports nested advice elements (of kind featureVersions and pluginVersions).
The corresponding application (ProductPublisherApplication) however does not.
This would be needed e.g. for specifying the launcher jar in the eclipse.ini file (-startup parameter).
Comment 1 Jan Lohre CLA 2009-08-10 12:07:43 EDT 
Created attachment 143921 [details]
proposed patch

adds commandline args (-pluginVersionsAdvice and -featureVersionsAdvice) to ProductPublisherApplication
Comment 2 John Arthorne CLA 2009-08-12 15:52:18 EDT 
Looks reasonable. What do you think Ian?
Comment 3 Ian Bull CLA 2009-08-12 16:53:18 EDT 
I'm going to be off-line for two weeks, but I'll assign this to myself and review the patch when I get back.  This should be in for M2.
Comment 4 John Arthorne CLA 2009-09-16 13:46:35 EDT 
Ian, I'm bumping these again to M3, but please review these bugs and pick a reasonable target (or remove the target if you have no immediate plans to work on them).
Comment 5 Ian Bull CLA 2010-04-16 16:26:45 EDT 
Created attachment 165145 [details]
updated patch

This is an updated patch that applies against head.
Comment 6 Ian Bull CLA 2010-04-16 18:35:02 EDT 
The change has been released and I added a few docs to the publisher page.
Comment 7 Thomas Watson CLA 2010-05-25 17:09:29 EDT 
Comment on attachment 143921 [details]
proposed patch

Thanks for the contribution Jan.