Community
Participate
Working Groups
Created attachment 142909 [details] Screenshot Hi, If you add an extension point in PDE which is deprecated then the dialog should display a warning so that the developer gets the immediate feedback that this extension point should not be used anymore. Screenshot which should give a little help in understanding this request is attached. For this screensho I assume that actionSet is deprecated. Best regards, Lars P.S. I open this bug in relation to blog entry http://www.vogella.de/blog/2009/07/29/deprecate-extension-points/ where I asked the question if that would be useful. I got the feedback over twitter that I should open a bug for this request.
This definitely makes sense. A contribution from the community would make this a reality.
set a filter on deprecated extension point when we choose one (as a checkbox as the existing “Show only extension points from the required plugin”) will be a "good warning" too
Created attachment 142959 [details] Screenshot @Curtis I like the filter idea. What do you think? I did the UI changes, please see the screenshot for the example
When the filter is turned off are we just going to show the deprecated points the same as the others? I would prefer just informing the user the extension point they are adding is deprecated (as a wizard warning and maybe a different icon). Adding more options to the dialog makes it harder to use and I expect most users are looking for a specific extension and might be confused when they can't find it.
Created attachment 143092 [details] Warnings & Icons Attached a screenshots with warnings and different icons. Sorry, for the confusion I was definitely planning to do this but wanted to hear the opinion about the additional check box. I personally like the idea to hide "old" stuff as this would display only the relevant content. But I remove the option in the hope that the patch get quickly accepted; I can add it later if someone thinks it makes sence. Is the screenshot ok? If yes I upload the patch.
Created attachment 143093 [details] with Warning Now screenshot shows also the warning ;-)
How can you indicate the right extension point to use is o.e.ui.commands, since we don't have any metadata telling what is the suggested successor of a deprecated ext point? WRT the icon, could you use an 8x8 overlay instead of a totally different icon? By the way l, did you implement tthis at PDELabelProvider level, in order that we can benefit from this everywhere in the UI?
Created attachment 143094 [details] Message alligned with existing Message aligned with standard message.
Created attachment 143095 [details] Patch @Benjamin: I guess it is easier to attach the patch so that you can see for yourself. ;-) My optinion is that the description of the deprecated extension point (ep) should contain a reference to its successor. The icon and warning will alert the user to read the description. Please feel free to use any icon you like; I used ISharedImages.IMG_OBJS_WARN_TSK but I have absolutely no preference in the warning icon. WRT the lableprovider: PointSelectionPage defines its own label provider which I adjusted.
Want to review Benjamin?
The provided patch had some issues (not using constants, icons instead of overlays, messages that wouldn't go away, etc.) so I wrote a new fix. Fixed in HEAD, see PointSelectionPage.java Let us know if the fix isn't enough.
Looks perfect. Thank you.
