Bug 284636 - [CSS] readme where to find webby.css
Summary: [CSS] readme where to find webby.css
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 0.9   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.9 RC2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: readme
Depends on:
Blocks:
 
Reported: 2009-07-24 16:37 EDT by Kevin McGuire CLA
Modified: 2009-07-27 11:59 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin McGuire CLA 2009-07-24 16:37:54 EDT 
We need in the readme instructions on 

1) how to find the webby.css file on disk so you can change the styling, and
2) the plugin.xml property to change if you want to point to a different css file

See recent e4-dev post (will update this bug with a ptr to it)
Comment 1 Benjamin Cabé CLA 2009-07-24 16:43:32 EDT 
(In reply to comment #0)
> 2) the plugin.xml property to change if you want to point to a different css
> file

How about externalizing this property in the plugin.properties? This could sound like it doesn't make that a difference, but I believe this is a more elegant way to do deal with configuration stuff

<property 
    name="applicationCSS" 
    value="%applicationCSS"> 
</property>
Comment 2 John Arthorne CLA 2009-07-24 17:33:03 EDT 
How's this:

http://eclipse.org/e4/development/readme/readme_e4_0.9.html#R-Demos-CSS

We could potentially also add a pointer to documentation on what style elements are supported on each widget/part. It seemed a bit long-winded to put all that in the readme directly.
Comment 3 Kevin McGuire CLA 2009-07-27 11:48:55 EDT 
(In reply to comment #2)
> How's this:
> 
> http://eclipse.org/e4/development/readme/readme_e4_0.9.html#R-Demos-CSS

Thanks John looks good. 
 
> We could potentially also add a pointer to documentation on what style elements
> are supported on each widget/part. It seemed a bit long-winded to put all that
> in the readme directly.

See http://wiki.eclipse.org/E4/CSS/SWT_Mapping (which needs updating)

(In reply to comment #1)
> How about externalizing this property in the plugin.properties? This could
> sound like it doesn't make that a difference, but I believe this is a more
> elegant way to do deal with configuration stuff
> 
> <property 
>     name="applicationCSS" 
>     value="%applicationCSS"> 
> </property> 

Hmmm, interesting idea, but maybe for 0.9 it's simpler for developers to see the key/value together in the plugin so they know how it works. In a "real" product I think I'd expect to find it in eclipse.ini.

The confusing part I worry about is the need to dig down to the product plugin with the "vSomeBuildNumber".  I'd rather the CSS directory be at the top level, like:

  /eclipse
    eclipse.exe
    eclipse.ini
    ...
    /CSS

or even
  /eclipse
    eclipse.exe
    eclipse.ini
    ...
    /configuration
      /CSS  

I guess post 0.9 sigh...
Comment 4 John Arthorne CLA 2009-07-27 11:59:50 EDT 
Marking fixed.