Bug 284401 - Need to implement ScopingNode#canAddDeclaration
Summary: Need to implement ScopingNode#canAddDeclaration
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: Photran.Refactoring Engine (show other bugs)
Version: 4.0   Edit
Hardware: All All
: P1 blocker (vote)
Target Milestone: ---   Edit
Assignee: Jeffrey Overbey CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 285054
  Show dependency tree
 
Reported: 2009-07-23 07:58 EDT by Jeffrey Overbey CLA
Modified: 2009-10-08 10:48 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeffrey Overbey CLA 2009-07-23 07:58:18 EDT 
The code in the Rename refactoring that determines whether a particular name can be added to a given scope should be moved into a method on ScopingNode (perhaps ScopingNode#canAddDeclaration) so it can be reused in Kurt's Move refactoring.

(Kurt, I'm copying you on this bug so you'll know when I get this done.)
Comment 1 Jeffrey Overbey CLA 2009-09-21 23:27:48 EDT 
MakePrivateEntityPublicTestSuite unit test 11 disabled until this is implemented
Comment 2 Jeffrey Overbey CLA 2009-09-21 23:41:09 EDT 
Also had to temporarily disable one unit test in Common Consistent refactoring and two in Minimize Only List; are these related?
Comment 3 Kurt Hendle CLA 2009-09-22 11:48:50 EDT 
I don't think those should be related. Test 11 MakePrivateEntityPublicTestSuite was the only test dealing with this specifically.
Comment 4 Jeffrey Overbey CLA 2009-09-22 12:56:48 EDT 
OK; I just wanted to make sure all the unit tests passed before committing it to CVS.  I'll take a look at those again...
Comment 5 Jeffrey Overbey CLA 2009-10-08 08:27:40 EDT 
Implemented as AbstractFortranRefactoring#checkIfDeclarationCanBeAddedToScope
Comment 6 Jeffrey Overbey CLA 2009-10-08 10:48:05 EDT 
There is one problem (see FIXME in CheckCanAddDeclTestCase); otherwise this appears to be working correctly.  Committed to CVS.

Kurt, could you please look at the disabled test case for Make Private Public?  Thanks.