Bug 284263 - Duplicated/inconsistent logic for default debugger selection
Summary: Duplicated/inconsistent logic for default debugger selection
Status: NEW
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug (show other bugs)
Version: 6.0   Edit
Hardware: Other Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: cdt-debug-inbox@eclipse.org CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-22 09:32 EDT by Vladimir Prus CLA
Modified: 2020-09-04 15:20 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Prus CLA 2009-07-22 09:32:20 EDT 
CDebuggerTab (generic, not DSF), appears to have two bits of logic to decide what the default debugger should be. First, in setDefaults, second in loadDebuggerComboBox (where defaultSelection) is computed. Those bits of code appear to be different -- one is using matching on configs's getSupportedBuildConfigPattern, while the other is using validatePlatform. It is not clear why different logic is necessary. It seems like either one copy should be removed, or else a function should be extracted/generalized.