Bug 28400 - JavaEditorPreferencePage and JavaColorManager leak Colors
Summary: JavaEditorPreferencePage and JavaColorManager leak Colors
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 2.1   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 2.1 M5   Edit
Assignee: JDT-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2002-12-16 12:08 EST by Adam Kiezun CLA
Modified: 2003-01-27 12:20 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Kiezun CLA 2002-12-16 12:08:10 EST 
20021216
everytime you do this:
1. open java editor pref page
2. close the pref page

you end up having allocated and not disposed 8 colors

1 is allocated like this
	at
org.eclipse.jdt.internal.ui.preferences.JavaEditorPreferencePage.createColor(JavaEditorPreferencePage.java:560)
	at
org.eclipse.jdt.internal.ui.preferences.JavaEditorPreferencePage.initializeViewerColors(JavaEditorPreferencePage.java:534)
	at
org.eclipse.jdt.internal.ui.preferences.JavaEditorPreferencePage.createPreviewer(JavaEditorPreferencePage.java:493)
	at
org.eclipse.jdt.internal.ui.preferences.JavaEditorPreferencePage.createSyntaxPage(JavaEditorPreferencePage.java:433)
	at
org.eclipse.jdt.internal.ui.preferences.JavaEditorPreferencePage.createContents(JavaEditorPreferencePage.java:942)
	at org.eclipse.jface.preference.PreferencePage.createControl(PreferencePage.java:209)


and the other 7 are allocated like this:
	at
org.eclipse.jdt.internal.ui.text.JavaColorManager.getColor(JavaColorManager.java:62)
	at
org.eclipse.jdt.internal.ui.text.JavaColorManager.getColor(JavaColorManager.java:85)
	at
org.eclipse.jdt.internal.ui.text.AbstractJavaScanner.addToken(AbstractJavaScanner.java:90)
	at
org.eclipse.jdt.internal.ui.text.AbstractJavaScanner.initialize(AbstractJavaScanner.java:75)
	at
org.eclipse.jdt.internal.ui.text.java.JavaCodeScanner.<init>(JavaCodeScanner.java:126)
	at org.eclipse.jdt.ui.text.JavaTextTools.<init>(JavaTextTools.java:80)
	at
org.eclipse.jdt.internal.ui.preferences.JavaEditorPreferencePage.createPreviewer(JavaEditorPreferencePage.java:486)
	at
org.eclipse.jdt.internal.ui.preferences.JavaEditorPreferencePage.createSyntaxPage(JavaEditorPreferencePage.java:433)
	at
org.eclipse.jdt.internal.ui.preferences.JavaEditorPreferencePage.createContents(JavaEditorPreferencePage.java:942)
	at org.eclipse.jface.preference.PreferencePage.createControl(PreferencePage.java:209)
Comment 1 Dani Megert CLA 2003-01-27 12:20:24 EST 
Fixed.
Available in builds > N20030127