Bug 283299 - Complete SourceRange API
Summary: Complete SourceRange API
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.6 M1   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2009-07-13 07:27 EDT by Markus Keller CLA
Modified: 2009-08-05 01:33 EDT (History)
3 users (show)

See Also:

Attachments
Proposed fix (1.85 KB, patch)
2009-07-14 15:51 EDT, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2009-07-13 07:27:15 EDT 
Follow-up to bug 88265

- constructor of SourceRange is missing Javadoc
- bug 88265 comment 11: mention the helper method in the Javadoc of ISourceRange
- ISourceRange should link to the default implementation (@see tag and blurb like in ITextSelection)
Comment 1 Markus Keller CLA 2009-07-14 04:54:13 EDT 
Dani and I talked again about making the implementation class SourceRange final. It turned out that we could move our additional constructors into a factory and the other methods into a utility class, so we don't need to subclass SourceRange any more.

Since this is fact just an unmodifiable value class (like e.g. Integer), it should be final. You can still remove the 'final' later if really necessary.
Comment 2 Olivier Thomann CLA 2009-07-14 15:49:57 EDT 
Released for 3.6M1.
Markus, please verify this meets your expectations.
Comment 3 Olivier Thomann CLA 2009-07-14 15:51:11 EDT 
Created attachment 141561 [details]
Proposed fix

'final' was already added before the patch was generated.
Comment 4 Srikanth Sankaran CLA 2009-08-05 01:33:45 EDT 
Verified for 3.6M1 by code inspection.