Description Peter Becker 2009-07-07 23:41:55 EDT

The new dead code detection feature in Galileo warns about this bit of code:

private static final boolean ALLOW_DOMAIN_LITERALS = false;
private static final String domain = ALLOW_DOMAIN_LITERALS ? rfc2822Domain : rfc1035DomainName;

Since the true branch of the ternary if can not be reached, this is correct, but somehow it should be classified as trivial and thus treated in the same manner as this code:

private static final boolean ALLOW_DOMAIN_LITERALS = false;
private static final String domain;
static {
    if(ALLOW_DOMAIN_LITERALS) {
        domain = rfc2822Domain;
    } else {
        domain= rfc1035DomainName;
    }
}

This second version is ignored. Treating the ternary if different seems inconsistent and putting compile-time configuration into static final booleans seems a common enough case to justify special treatment.