Bug 282449 - Keybindings in RAP
Summary: Keybindings in RAP
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: JFace (show other bugs)
Version: 1.3   Edit
Hardware: All All
: P3 enhancement with 13 votes (vote)
Target Milestone: 1.4 M5   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard: plan-version=1.4 plan-theme=single-so...
Keywords:
Depends on: 324555
Blocks: 348559
  Show dependency tree
 
Reported: 2009-07-05 02:07 EDT by Lars Vogel CLA
Modified: 2011-07-07 06:00 EDT (History)
13 users (show)

See Also:

Attachments
First draft (505.21 KB, patch)
2010-10-04 04:24 EDT, Ivan Furnadjiev CLA 		no flags Details | Diff
Updated patch (518.91 KB, patch)
2010-11-25 10:10 EST, Tim Buschtoens CLA 		no flags Details | Diff
Updated patch to HEAD (353.61 KB, patch)
2011-01-24 12:51 EST, Ivan Furnadjiev CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2009-07-05 02:07:43 EDT 
It would be nice if RAP could support keybindings, e.g. CTRL+S for saving.
Comment 1 Ralf Sternberg CLA 2010-03-23 15:09:05 EDT 
As long as key bindings are missing in RAP, this FAQ explains a workaround:
http://wiki.eclipse.org/RAP/FAQ#How_do_I_implement_a_key_binding_that_triggers_a_Command
Comment 2 Ivan Furnadjiev CLA 2010-10-04 04:24:51 EDT 
Created attachment 180140 [details]
First draft
Comment 3 Bogdan B. CLA 2010-10-14 09:27:48 EDT 
Will this bug cover also the changing the focus to the next focusable widget on pressing the TAB key, like in RCP?
If not, is there another bug which covers it, or some document specifying how RAP should behave on TAB?
Comment 4 Ivan Furnadjiev CLA 2010-10-17 12:54:36 EDT 
Hi Bogdan, this bug is only about the keybindings support in RAP. Focus traverse should work in RAP in the same way like in RCP. If you have any particular problem with focus traversal on TAB, please file a separate bugzilla with a snippet to reproduce it. Thanks.
Comment 5 Tim Buschtoens CLA 2010-11-25 10:10:09 EST 
Created attachment 183858 [details]
Updated patch

Updated version of the patch. Identical to the first draft, only adapted to current CVS HEAD.
Comment 6 Ivan Furnadjiev CLA 2011-01-24 12:51:23 EST 
Created attachment 187451 [details]
Updated patch to HEAD
Comment 7 Ralf Sternberg CLA 2011-01-27 13:37:27 EST 
Applied a modified version of attachment 187451 [details] to CVS HEAD. This implementation supports JFace key bindings as they are used by the workbench, but leaves some issues to be addressed later: bug 335597, bug 335598.
Comment 8 Ivan Furnadjiev CLA 2011-03-11 03:01:20 EST 
We want to provide a possibility for RWT standalone applications (without JFace/Workbench) to define its own keybindings. Currently, the format of the keybinding in the keybinding array is "<int modifier mask>,<int natural key>" which is not user friendly. We have to change it to standard string keybinding representation like "ALT+CTRL+M".
Comment 9 Ivan Furnadjiev CLA 2011-03-11 10:57:59 EST 
The format of the internal key binding is changed to a string readable form ( "CTRL+ALT+F1" ). Changes are in CVS HEAD.
Comment 10 Stephan Leicht Vogt CLA 2011-06-07 09:07:35 EDT 
If you set DELETE to the active keys the default behavior, delete text in textfields, does not work anymore.
Comment 11 Ivan Furnadjiev CLA 2011-06-07 09:19:27 EDT 
Stephan, as this bug has been opened for the initial implementation, would you mind to open a separate bug report for this issue. Thanks.
Comment 12 Stephan Leicht Vogt CLA 2011-06-07 09:24:24 EDT 
Sure, I opened Bug 348559.