Community
Participate
Working Groups
If no connections have been created yet, trying to create a new one using "New Connection" wizard won't get a drop list of host names for you to choose. It would better to provide "LOCALHOST" in the drop list in this case.
Created attachment 140654 [details] Fixing the bug Index: src/org/eclipse/rse/ui/SystemWidgetHelpers.java =================================================================== --- src/org/eclipse/rse/ui/SystemWidgetHelpers.java (revision 11) +++ src/org/eclipse/rse/ui/SystemWidgetHelpers.java (working copy) @@ -1208,7 +1208,12 @@ //System.out.println("TipId: " + ISystemConstants.RESID_HOSTNAME_TIP); Combo combo = createCombo(parent, listener, SystemResources.RESID_CONNECTION_HOSTNAME_TIP); //System.out.println("Tip : " + combo.getToolTipText()); - combo.setItems(RSECorePlugin.getTheSystemRegistry().getHostNames(systemType)); + // Fix bug#282242: No default host names if no connection has been created. + String[] hostNames = RSECorePlugin.getTheSystemRegistry().getHostNames(systemType); + if (hostNames.length == 0) { + hostNames = new String[] { "LOCALHOST" }; + } + combo.setItems(hostNames); combo.select(0); return combo; }
Hi Zhou, thanks for the contribution! Note that these contributions need the following: 1) modified files need to contain your copyright line 2) a legal disclaimer is needed for your patch as per http://www.eclipse.org/dsdp/tm/development/committer_howto.php#external_contrib
Created attachment 140734 [details] Fixing the bug and fix copyrights Legal Message: I, Zhou Renjian, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. I am authorized by my employer, Shanghai Kortide, to make this contribution under the EPL. /org.eclipse.rse.ui/src/org/eclipse/rse/ui/SystemWidgetHelpers.java
Comment on attachment 140734 [details] Fixing the bug and fix copyrights Patch format doesn't work for my Eclipse so I have to apply the changes manually.
I've committed the change to cvs.
Comment on attachment 140654 [details] Fixing the bug Obsoleted by later patch.
