Bug 28183 - search: 36% of time is spent in sorting the search results
Summary: search: 36% of time is spent in sorting the search results
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P2 normal (vote)
Target Milestone: 2.1 M5   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2002-12-12 11:01 EST by Adam Kiezun CLA
Modified: 2003-01-17 07:59 EST (History)
0 users

See Also:

Attachments
searching (23.15 KB, text/plain)
2002-12-12 11:01 EST, Adam Kiezun CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Kiezun CLA 2002-12-12 11:01:13 EST 
20021210
search for refs to Test in junit
sorting 224 results takes almost 3 seconds
a lot (36%) of that time is spent in sorting the results
most of that time, in turn, is spent in calculating the text
Comment 1 Adam Kiezun CLA 2002-12-12 11:01:35 EST 
Created attachment 2771 [details]
searching
Comment 2 Dani Megert CLA 2003-01-16 12:49:23 EST 
With my JUnit source I only get 136 references to type "Test" and could not find
severe sorting problems. I then tried the following test case:

  Search for method references to *test*. 

This revealed the problems with sorting:
- Override indicators have to go away
- The most expensive thing is getting the text where the Java element is created
from the handle each time
Comment 3 Dani Megert CLA 2003-01-17 07:59:56 EST 
Another problem is the exists() test when getting the image.

Fixed all of these cases.
It's now very fast!