Bug 281687 - [markers] ConcurrentModificationException during AJBuilder.postCallListeners
Summary: [markers] ConcurrentModificationException during AJBuilder.postCallListeners
Status: NEW
Alias: None
Product: AJDT
Classification: Tools
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: AJDT-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-26 12:17 EDT by Andrew Eisenberg CLA
Modified: 2010-06-16 18:12 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Eisenberg CLA 2009-06-26 12:17:29 EDT
This bug has come out of Bug 278496.

The following 2 aspects are causing ConcurrentModificationException during the call to AJBuilder.postCallListeners:

<pre>
public aspect SQL_Exception {
	public pointcut callToSqlException() : call(* java.sql.SQLException+.*(..)) || 
		call(java.sql.SQLException..new(..));

	before() : callToSqlException(){

	}
}

public aspect JDBC_Driver {
	public pointcut callToJDBC() : call(* java.sql.DriverManager+.*(..)) || 
			call(java.sql.DriverManager..new(..));

	before() : callToJDBC(){

	}
} 
</pre>

Trying to reproduce this in my own workspace with no luck.
Comment 1 Andrew Eisenberg CLA 2009-06-26 12:22:53 EDT
BuildListeners are only added and removed during the startup and the shutdown of the ajdt core and ui plugins (unless there is a third party plugin that adds more listeners).

It is conceivable that if a build is finishing during the time when ajdt.ui is shutting down the ConcurrentModificationException can be thrown.  A way around this might be to synchronize all methods that access the build listeners.
Comment 2 Andrew Eisenberg CLA 2009-06-26 12:30:32 EDT
OK...just committed a new version of AJDT where calls to the offending method are synchronized.  This might avoid your problem.

Since I cannot reproduce your problem on my end, I cannot be sure that it will address your problem, so please try it.  Build will be available in about 2-3 hours.
Comment 3 Andrew Eisenberg CLA 2009-07-03 13:40:32 EDT
Any update on this?  Still receiving ConcurrentModification errors?
Comment 4 Dharma CLA 2009-07-03 13:46:10 EDT
(In reply to comment #3)
> Any update on this?  Still receiving ConcurrentModification errors?
> 

Hi, I am waiting for Andrew to react. He mentioned that will look into memory consumptions on large systems. I hope he gets some time to do. Yes, I still get ConcurrentModification and sometimes also get Out of memory error.
Comment 5 Andrew Eisenberg CLA 2009-07-03 13:59:24 EDT
Are you on 3.4 or 3.5?
Comment 6 Dharma CLA 2009-07-03 16:25:04 EDT
(In reply to comment #5)
> Are you on 3.4 or 3.5?
Hi, I am on 3.4.
Comment 7 Andrew Eisenberg CLA 2009-09-30 14:37:42 EDT
Move to the 2.0.2 release.
Comment 8 Andrew Eisenberg CLA 2010-04-28 19:25:39 EDT
Try to solve for 2.1.0.
Comment 9 Andrew Eisenberg CLA 2010-06-16 18:12:07 EDT
Determining what will be tackled for 2.1.1 release.