Bug 281681 - Stale code in CompilerOptions
Summary: Stale code in CompilerOptions
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.5   Edit
Hardware: Other All
: P3 minor (vote)
Target Milestone: 3.6 M1   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-26 11:43 EDT by Stephan Herrmann CLA
Modified: 2010-05-28 10:29 EDT (History)
2 users (show)

See Also:

Attachments
simple patch (1.71 KB, patch)
2009-06-26 14:31 EDT, Stephan Herrmann CLA 		john.arthorne: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2009-06-26 11:43:39 EDT 
This is from bug 245973 comment 7:
I found some left-overs in CompilerOptions which should probably be removed:
 * field OptionToIrritants
 * method long optionKeyToIrritant(String optionName)
I was trying to find a correct and safe type for this map, but actually
the code looks broken here - undecided whether to hold Longs or Integers.
=> should someone try to use this stuff (s)he will end up getting CCEs.
Comment 1 Olivier Thomann CLA 2009-06-26 13:40:27 EDT 
Stephan, feel free to provide a patch.
Comment 2 Stephan Herrmann CLA 2009-06-26 14:31:13 EDT 
Created attachment 140270 [details]
simple patch

> Stephan, feel free to provide a patch.

Nothing easier than this ;-)
I just didn't want to prepare another patch that would not 
be picked up by a committer.
Comment 3 Olivier Thomann CLA 2009-06-26 14:47:30 EDT 
Released for 3.6M1.
Thanks for the patch. If you have other patches not committed, please send me the bug ids.
Comment 4 Olivier Thomann CLA 2009-06-26 14:47:58 EDT 
Fixed.
Verification implies to check the code.
Comment 5 Satyam Kandula CLA 2009-08-04 11:21:15 EDT 
Verified the code in 3.6M1 using build I20090802-2000