Bug 28139 - Highlight unused method parameters that are not inherited
Summary: Highlight unused method parameters that are not inherited
Status: RESOLVED DUPLICATE of bug 25204
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 enhancement (vote)
Target Milestone: 2.1 RC1   Edit
Assignee: JDT-Core-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-12-11 16:36 EST by IH CLA
Modified: 2003-02-12 06:58 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description IH CLA 2002-12-11 16:36:55 EST
I like how eclipse now has the ability to highlight unused imports.  I think an
equally valuable feature would be to highlight unused method arguments.  ie.

public static String getProductName(String productId, String locale)  {

return ProductDao.getName(productId);

}

warning:  method argument locale not used in method.   where locale would be
underlined in the method signature.
Comment 1 Adam Kiezun CLA 2002-12-12 04:19:58 EST
there's a compiler preference to hightlight them
see preferences > java > compiler > unused parameters
Comment 2 IH CLA 2002-12-12 13:02:41 EST
I'll right I see it, thanks!  So then how about the default setting should be
warning and not ignore.  
Comment 3 Adam Kiezun CLA 2002-12-12 13:10:44 EST
would be a bad choice - think about all interface methods that you're forced to 
implement sometimes and don't care about their params
Comment 4 IH CLA 2002-12-12 13:16:42 EST
Yeah you are right,  just noticed that.  What about highlighting only usused
parameters in methods that are not part of the interface/inherited, too much
processing?  This is really what I would be interested in having highlighted.  

 
Comment 5 IH CLA 2002-12-12 20:44:37 EST
What about highlighting only usused parameters in methods that are not inherited
from an interface or class?

This is really what I would be interested in having highlighted.
Comment 6 Adam Kiezun CLA 2002-12-13 04:30:26 EST
it'd the compiler that reports these warnings
Comment 7 Philipe Mulet CLA 2002-12-13 06:40:14 EST
Will see how we can make this warning more useful post 2.1
Comment 8 Philipe Mulet CLA 2003-02-11 06:40:36 EST
Resurrecting for investigation, as per request for RC1.
Comment 9 Philipe Mulet CLA 2003-02-12 06:58:52 EST

*** This bug has been marked as a duplicate of 25204 ***