Community
Participate
Working Groups
I've created a generic "capabilities plugin" that should enable the preferences page and capabilities that are normally provided by the org.eclipse.sdk. If that plugin can be added to the jee feature, as the intro plugin is, then we will be cooking with gas! (patch attached). The remaining question is how to get in other contributed capabilities. These plugins are part of the "normal" galileo repository. Can they just be added to the jee feature and found and included magically? The following this the list of plugins ... in order of certainty :) org.eclipse.wtp.javascript.capabilities org.eclipse.wtp.jee.capabilities org.eclipse.wtp.web.capabilities org.eclipse.wtp.xml.capabilities org.eclipse.datatools.capabilities org.eclipse.mylyn.ide.capabilities org.eclipse.rse.ui.capabilities org.eclipse.emf.capabilities org.eclipse.gef.examples.ui.capabilities org.eclipse.emf.ecoretools.ui.capabilities This is important to fix for reasons stated in bug 235089.
Created attachment 139396 [details] patch to add plugin to feature
Adding Thomas in case he can advise on easiest way to get the repository plugins added to jee feature.
Oh, for the map file, I forgot to give you the cvs location ... not sure where the map files is? but the location is similar to the intro plugin: webtools.releng/plugins/org.eclipse.wtp.epp.package.capabilities
Patch applied to HEAD, updated the epp.rmap file in the EPP build.
Okay, seems to be working - at least I could enable the old Eclipse Update Manager. Will be available in the next build.
Created attachment 139439 [details] includes other capability plugin providers to feature.xml Thanks Markus. Haven't seen in a build yet, but since you didn't respond to question about how to include other capability plugins thought I'd add this patch to force the issue. Is this the right way to include them in the package? Remember, these are part of the Galileo repo ... we just need to pull them in. Thanks.
I've applied the patch and will run another build as soon as the current one is finished. If this patch is not working, I will try to add the dependencies to the p2.inf file. Maybe this is the cleaner solution but we'll see.
Created attachment 139504 [details] patch to correct typo The previous patch worked, in the sense that the plugins were included with the zip file 20090617-2125 bug for some reason did not show up in the actual preferences. Not sure why, but upon investigating saw there was a "typo" in previous patch where I included the 'javascript' one twice and missed the 'xml' one. Doubt that prevents these contributed ones from showing up in preferences ... but, should be fixed.
I should note, if I install "galileo capabilities" from Galileo repository, then those capabilities _do_ show up in the jee ide. But, those are a very large set, and was hoping to install just those specific to jee ide. Thomas, does the Galileo Builder do anything "special" about capabilities ... well, I know it does a lot special :) ... but anything "product" related?
Created attachment 139506 [details] patch to bind and enable capabilities I remember now ... we've got a sort of "funky" way of contributing capabilities, so there's two parts. Here's the "binding" part (that is in the 'galileo' plugin, which is why it works there.). This is for mylyn and wtp. It's a start.
Created attachment 139507 [details] adds RSE to WTP and Mylyn
Created attachment 139508 [details] forgot datatools
Created attachment 139509 [details] removes some capabiltiy plugins I'd like to remove the emf and gef related capabilties plugins. I'm not _exactly_ sure how they are defined, but appear to be "modeling related" and we don't want to get into that! (at least this release :) It also has the 'javascript' / 'xml' fix.
I was going through all the patches - most patches are changing org.eclipse.wtp.epp.package.capabilities plugins which is located in your CVS. I assume that you didn't expect me to change this, right? The only patch that I applied for now is the last one (patch 139509). I will start another build soon to see what happened.
(In reply to comment #14) > I was going through all the patches - most patches are changing > org.eclipse.wtp.epp.package.capabilities plugins which is located in your CVS. > I assume that you didn't expect me to change this, right? The only patch that I > applied for now is the last one (patch 139509). I will start another build soon > to see what happened. > Oh, thanks. I forgot. I've just now released _my_ changes ... 9:05 Eastern. (and a package build appears to be in progress, for over an hour, so will need a respin). Sorry about that.
A new build is running... but the build of the EPP repository is it what worries me. The full log of the EPP repository build is here: https://build.eclipse.org/hudson/job/epp-repository-build/155/console - there are some warnings in build.workspace and at the end of build.site. install.buckminster: [java] Installing org.eclipse.buckminster.cmdline.product 1.1.350.r10356. [java] Installing org.eclipse.buckminster.core.headless.feature.feature.group 1.1.350.r10382. [java] Installing org.eclipse.buckminster.cvs.headless.feature.feature.group 1.0.350.r10356. [java] Installing org.eclipse.buckminster.pde.headless.feature.feature.group 1.1.350.r10381. [java] Installing org.eclipse.platform.feature.group 3.5.0.v20090611a-9gEeG1HFtQcmRThO4O3aR_fqSMvJR2sJ. [java] Operation completed in 34382 ms. build.workspace: [java] Warning: Problems parsing plug-in manifest for: "org.eclipse.wtp.epp.package.capabilities". [java] Warning: Unknown element "categoryActivityBinding", found within a "plugin", ignored (line: 245). [java] Warning: Unknown element "defaultEnablement", found within a "plugin", ignored (line: 248). [java] Warning: Unknown element "categoryActivityBinding", found within a "plugin", ignored (line: 252). [java] Warning: Unknown element "defaultEnablement", found within a "plugin", ignored (line: 255). [java] Warning: Unknown element "categoryActivityBinding", found within a "plugin", ignored (line: 259). [java] Warning: Unknown element "defaultEnablement", found within a "plugin", ignored (line: 262). [java] Warning: Unknown element "categoryActivityBinding", found within a "plugin", ignored (line: 272). [java] Warning: Unknown element "defaultEnablement", found within a "plugin", ignored (line: 275). [java] Warning: Unknown element "categoryActivityBinding", found within a "plugin", ignored (line: 281). [java] Warning: Unknown element "defaultEnablement", found within a "plugin", ignored (line: 284). [java] Warning: Unknown element "categoryActivityBinding", found within a "plugin", ignored (line: 290). [java] Warning: Unknown element "defaultEnablement", found within a "plugin", ignored (line: 293). [java] Warning: Unknown element "categoryActivityBinding", found within a "plugin", ignored (line: 299). [java] Warning: Unknown element "defaultEnablement", found within a "plugin", ignored (line: 302). [java] Warning: Unknown element "categoryActivityBinding", found within a "plugin", ignored (line: 306). [java] Warning: Unknown element "defaultEnablement", found within a "plugin", ignored (line: 309). [java] Warning: Unknown element "categoryActivityBinding", found within a "plugin", ignored (line: 315). [java] Warning: Unknown element "categoryActivityBinding", found within a "plugin", ignored (line: 318). [java] Warning: Unknown element "defaultEnablement", found within a "plugin", ignored (line: 321). [java] Warning: Unknown element "defaultEnablement", found within a "plugin", ignored (line: 323). [java] Warning: Unknown element "defaultEnablement", found within a "plugin", ignored (line: 328). [java] Warning: Unknown element "categoryActivityBinding", found within a "plugin", ignored (line: 334). [java] INFO: Import complete. build.site: .... .... [java] [ant] Queueing site_329571270.zip for signing [java] [ant] Waiting for signing to complete. This may take more then 20 minutes. (Expect to see several 'Remote command failed' messages) [java] [ant] Signing host = build.eclipse.org, ls.result = ls /home/data/httpd/download-staging.priv/technology/epp//out20090618160145/site_329571270.zip : /home/data/httpd/download-staging.priv/technology/epp//out20090618160145/site_329571270.zip [java] [ant] Obtaining signed file from server [java] INFO: [end org.eclipse.epp.allpackages.feature:eclipse.feature$1.2.0.qualifier#OSGi#site.signed] [java] INFO: [start org.eclipse.epp.allpackages.feature:eclipse.feature$1.2.0.qualifier#OSGi#site.packed] [java] INFO: [end org.eclipse.epp.allpackages.feature:eclipse.feature$1.2.0.qualifier#OSGi#site.packed] [java] INFO: [start org.eclipse.epp.allpackages.feature:eclipse.feature$1.2.0.qualifier#OSGi#site.p2] [java] INFO: [end org.eclipse.epp.allpackages.feature:eclipse.feature$1.2.0.qualifier#OSGi#site.p2] [java] INFO: [start org.eclipse.epp.allpackages.feature:eclipse.feature$1.2.0.qualifier#OSGi#site.p2.zip] [java] INFO: [end org.eclipse.epp.allpackages.feature:eclipse.feature$1.2.0.qualifier#OSGi#site.p2.zip] [java] Warning: file /opt/public/technology/epp/epp_repo/galileo/epp.build/workspace/plugins/org.eclipse.wtp.epp.package.capabilities/plugin.xml, line 243: Element 'categoryActivityBinding' is not legal as a child of element 'plugin'. [java] Warning: file /opt/public/technology/epp/epp_repo/galileo/epp.build/workspace/plugins/org.eclipse.wtp.epp.package.capabilities/plugin.xml, line 247: Element 'defaultEnablement' is not legal as a child of element 'plugin'. [java] Warning: file /opt/public/technology/epp/epp_repo/galileo/epp.build/workspace/plugins/org.eclipse.wtp.epp.package.capabilities/plugin.xml, line 257: Element 'categoryActivityBinding' is not legal as a child of element 'plugin'. [java] Warning: file /opt/public/technology/epp/epp_repo/galileo/epp.build/workspace/plugins/org.eclipse.wtp.epp.package.capabilities/plugin.xml, line 270: Element 'categoryActivityBinding' is not legal as a child of element 'plugin'. [java] Warning: file /opt/public/technology/epp/epp_repo/galileo/epp.build/workspace/plugins/org.eclipse.wtp.epp.package.capabilities/plugin.xml, line 283: Element 'defaultEnablement' is not legal as a child of element 'plugin'. [java] Warning: file /opt/public/technology/epp/epp_repo/galileo/epp.build/workspace/plugins/org.eclipse.wtp.epp.package.capabilities/plugin.xml, line 297: Element 'categoryActivityBinding' is not legal as a child of element 'plugin'. [java] Warning: file /opt/public/technology/epp/epp_repo/galileo/epp.build/workspace/plugins/org.eclipse.wtp.epp.package.capabilities/plugin.xml, line 304: Element 'categoryActivityBinding' is not legal as a child of element 'plugin'. [java] Warning: file /opt/public/technology/epp/epp_repo/galileo/epp.build/workspace/plugins/org.eclipse.wtp.epp.package.capabilities/plugin.xml, line 316: Element 'categoryActivityBinding' is not legal as a child of element 'plugin'. [java] Warning: file /opt/public/technology/epp/epp_repo/galileo/epp.build/workspace/plugins/org.eclipse.wtp.epp.package.capabilities/plugin.xml, line 327: Element 'defaultEnablement' is not legal as a child of element 'plugin'. [java] Warning: file /opt/public/technology/epp/epp_repo/galileo/epp.build/workspace/plugins/org.eclipse.wtp.epp.package.capabilities/plugin.xml, line 332: Element 'categoryActivityBinding' is not legal as a child of element 'plugin'. [java] Found 10 warnings
Yepp, the logfile of a local package build on my machine shows this error. A build that includes the latest capabilities plugin will show up here soon: http://build.eclipse.org/technology/epp/epp_build/35/download/20090618-1603/ !SESSION 2009-06-18 18:25:32.145 ----------------------------------------------- eclipse.buildId=I20090611-1540 java.version=1.6.0_13 java.vendor=Sun Microsystems Inc. BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_GB Framework arguments: -product org.eclipse.epp.package.jee.product Command-line arguments: -os linux -ws gtk -arch x86_64 -product org.eclipse.epp.package.jee.product -consoleLog !ENTRY org.eclipse.equinox.registry 2 1 2009-06-18 18:25:45.896 !MESSAGE Problems parsing plug-in manifest for: "org.eclipse.wtp.epp.package.capabilities". !SUBENTRY 1 org.eclipse.equinox.registry 2 1 2009-06-18 18:25:45.897 !MESSAGE Unknown element "categoryActivityBinding", found within a "plugin", ignored (line: 245). !SUBENTRY 1 org.eclipse.equinox.registry 2 1 2009-06-18 18:25:45.899 !MESSAGE Unknown element "defaultEnablement", found within a "plugin", ignored (line: 248). !SUBENTRY 1 org.eclipse.equinox.registry 2 1 2009-06-18 18:25:45.900 !MESSAGE Unknown element "categoryActivityBinding", found within a "plugin", ignored (line: 252). !SUBENTRY 1 org.eclipse.equinox.registry 2 1 2009-06-18 18:25:45.901 !MESSAGE Unknown element "defaultEnablement", found within a "plugin", ignored (line: 255). !SUBENTRY 1 org.eclipse.equinox.registry 2 1 2009-06-18 18:25:45.902 !MESSAGE Unknown element "categoryActivityBinding", found within a "plugin", ignored (line: 259). !SUBENTRY 1 org.eclipse.equinox.registry 2 1 2009-06-18 18:25:45.903 !MESSAGE Unknown element "defaultEnablement", found within a "plugin", ignored (line: 262). !SUBENTRY 1 org.eclipse.equinox.registry 2 1 2009-06-18 18:25:45.904 !MESSAGE Unknown element "categoryActivityBinding", found within a "plugin", ignored (line: 272). !SUBENTRY 1 org.eclipse.equinox.registry 2 1 2009-06-18 18:25:45.905 !MESSAGE Unknown element "defaultEnablement", found within a "plugin", ignored (line: 275). !SUBENTRY 1 org.eclipse.equinox.registry 2 1 2009-06-18 18:25:45.906 !MESSAGE Unknown element "categoryActivityBinding", found within a "plugin", ignored (line: 281). !SUBENTRY 1 org.eclipse.equinox.registry 2 1 2009-06-18 18:25:45.907 !MESSAGE Unknown element "defaultEnablement", found within a "plugin", ignored (line: 284). !SUBENTRY 1 org.eclipse.equinox.registry 2 1 2009-06-18 18:25:45.909 !MESSAGE Unknown element "categoryActivityBinding", found within a "plugin", ignored (line: 290). !SUBENTRY 1 org.eclipse.equinox.registry 2 1 2009-06-18 18:25:45.910 !MESSAGE Unknown element "defaultEnablement", found within a "plugin", ignored (line: 293). !SUBENTRY 1 org.eclipse.equinox.registry 2 1 2009-06-18 18:25:45.911 !MESSAGE Unknown element "categoryActivityBinding", found within a "plugin", ignored (line: 299). !SUBENTRY 1 org.eclipse.equinox.registry 2 1 2009-06-18 18:25:45.912 !MESSAGE Unknown element "defaultEnablement", found within a "plugin", ignored (line: 302). !SUBENTRY 1 org.eclipse.equinox.registry 2 1 2009-06-18 18:25:45.913 !MESSAGE Unknown element "categoryActivityBinding", found within a "plugin", ignored (line: 306). !SUBENTRY 1 org.eclipse.equinox.registry 2 1 2009-06-18 18:25:45.914 !MESSAGE Unknown element "defaultEnablement", found within a "plugin", ignored (line: 309). !SUBENTRY 1 org.eclipse.equinox.registry 2 1 2009-06-18 18:25:45.915 !MESSAGE Unknown element "categoryActivityBinding", found within a "plugin", ignored (line: 315). !SUBENTRY 1 org.eclipse.equinox.registry 2 1 2009-06-18 18:25:45.916 !MESSAGE Unknown element "categoryActivityBinding", found within a "plugin", ignored (line: 318). !SUBENTRY 1 org.eclipse.equinox.registry 2 1 2009-06-18 18:25:45.918 !MESSAGE Unknown element "defaultEnablement", found within a "plugin", ignored (line: 321). !SUBENTRY 1 org.eclipse.equinox.registry 2 1 2009-06-18 18:25:45.919 !MESSAGE Unknown element "defaultEnablement", found within a "plugin", ignored (line: 323). !SUBENTRY 1 org.eclipse.equinox.registry 2 1 2009-06-18 18:25:45.920 !MESSAGE Unknown element "defaultEnablement", found within a "plugin", ignored (line: 328). !SUBENTRY 1 org.eclipse.equinox.registry 2 1 2009-06-18 18:25:45.921 !MESSAGE Unknown element "categoryActivityBinding", found within a "plugin", ignored (line: 334).
Apologies for sloppy work. I pasted those elements into "root" of plugin.xml, instead of in the activities extension. I've corrected and committed the fixes to our cvs repo. Fixes should be picked up in the next EPP build.
Okay, I'll wait for a new staging repository and start a new build then.
The current version looks pretty good (20090618-1920) I didn't notice, though, that the Mylyn and RSE capabilities define their "category" for the prefernces that I did not include. Hence, I've added them, approximately 10 PM Eastern time. So if/when the packages are re-built it will pick up the fix in org.eclipse.wtp.epp.package.capabilities
Oh, I meant to document the changes I added to the plugin.xml. <!-- Remote Access and Device Development category --> <category id="org.eclipse.galileo.dsdp.Category" description="%activity.cat.dsdp.desc" name="%activity.cat.dsdp" /> <!-- Task Management category --> <category id="org.eclipse.galileo.tasks.Category" description="%activity.cat.tasks.desc" name="%activity.cat.tasks" />
Created attachment 139637 [details] match to add mylyn.capability plugin to feature.xml I somehow missed the mylyn capabilities plugin in the feature.xml. Also, when I added the 2 categories in plugin.xml, in previous comment, I forgot to include the NL string in the plugin.properties file, so the NL key shows up on first page of "capabilities preferences". I've checked in that fix into the epp cap. plugin (from wtp) but will need this patch applied for Mylyn to show up. This is not a "stop ship" defect. If there's some other reason to respin, would be good to include this fix also ... but, it would not damage data or prevent the user from accomplishing anything.
I've changed my mind. I think this is important to fix for release, since there's been many bugs opened about lack of Capabilities in Java EE IDE, I think many people would see this ugliness ... and may not "trust" it to work for such an obvious error.
Patch applied to HEAD.
Created attachment 139656 [details] Preferences with missing I18N This is something that I found this morning - see screenshot of the preferences. There is an error with the internationalisation or someone forgot to include the properties file in the build.xml.
(In reply to comment #25) > There is an error with the internationalisation or someone forgot > to include the properties file in the build.xml. > Yes, this was the second part of my comment #22 and has been fixed in org.eclipse.wtp.epp.package.capabilities Thanks,
Created attachment 139677 [details] corrected mylyn capabilties plugin Poot. A build with the NL fix, and also including the Mylyn patch (20090620-1600) showed that the NL fix is good, but the Mylyn fix isn't. - id="org.eclipse.mylyn.compatibility" + id="org.eclipse.mylyn.ide.capabilities" The "org.eclipse.mylyn.compatibility" is something else, and presumably already included by some other Mylyn feature. So, 1) it doesn't fix the ommission on capabilities preference page. and 2) While technically "including it (the wrong one) twice" does not hurt anything, it could make updates much more difficult. If Mylyn, for example, had "an emergency patch" for it on their own update site, the installer would not allow the new version to be installed, because it would think "oh, the galileo features needs this other exact feature" ... hence the galileo feature would need to be patched too .... and not even sure there's an update site to get that from. I mean, we could make one ... but, the point it, even apparently simple and safe fixes can go awry. If we can not re-spin easily with the correct capabilities plugin in the feature.xml, then I suggest we'd have to use previous build that has the NL problem too :(
(In reply to comment #27) > corrected mylyn capabilties plugin > > - id="org.eclipse.mylyn.compatibility" > + id="org.eclipse.mylyn.ide.capabilities" I made this change in HEAD.
fixed long ago
