Community
Participate
Working Groups
Created attachment 137239 [details] Class which contains the advice I have attached 2 classes which easily demonstrate the problem: 1> Advice.java - Class which defines the advice to be applied to the test class 2> AOPTest.java - The class which has a method cleanup that is as simple as: " public static void doSomething() {} public static void cleanup() { try { doSomething(); } catch(Exception ex) { // ignore } } " When the main method is called on AOPTest.java the following output occurs: Exception in thread "main" java.lang.VerifyError: (class: example/AOPTest, method: cleanup_aroundBody2 signature: (Lorg/aspectj/lang/JoinPoint;)V) Stack size too large at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:164) at com.intellij.rt.execution.application.AppMain.main(AppMain.java:87) Note that "cleanup" does not have to be static, so the advised method being static does not seem to be an issue. There are also workarounds mentioned in AOPTest.java, however the problem is of course that the workaround is in the code being advised and I have not found one yet that can be applied at the pointcut. I am using Java 1.5.0_14, however I have tried it with 15 and 16 and they both fail. Interestingly enough though I tried it with 1.5.0_1 and it worked, so something changed so cause this. I also was originally running with AspectJ 1.6.2 and this problem occurred there as well. This also occurs using LTW as well as compile time weaving.
Created attachment 137240 [details] Test class which causes a VerifyError when advice is applied from Advice.java
you could try using a code style aspect (rather than annotation style) as a possible workaround until I can fix this.
I tried doing a code based aspect and the problem still exists. I am attaching the code based aspect that I used to apply advice on the previously attached AOPTest class. Please let me know if there is an additional path on the code based aspect that I could try. Thanks
Created attachment 137380 [details] Code base aspect which applies advice to AOPTest which displays the same bad behavior
fixed. The problem is that there is no 'apparent' activity against the stack in that simple method with the try catch, so it assigns it a stack depth of 0. This is incorrect because there is an exception handler and so at least one item gets put on the stack if the ex handler is entered. I've fixed it to allow for this situation. Your variants of the code simply caused some stack activity: public static void cleanup() { try { int x = 1; doSomething(); } catch(Exception ex) { // ignore } } or didnt have an exception handler: public static void cleanup() { doSomething(); } and then it got the depth correct anyway. thanks for simple test case. Fix will be in next dev build.
