Bug 277812 - [call hierarchy] [working sets] Add F1 Help for Call Hierarchy Filters, Expand With Constructors Dialog, Working Set Configuration Dialog , Working Set Assignments Dialog
Summary: [call hierarchy] [working sets] Add F1 Help for Call Hierarchy Filters, Expan...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 RC3   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation
: 228412 277301 277302 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-05-26 04:46 EDT by Raksha Vasisht CLA
Modified: 2009-05-29 04:00 EDT (History)
3 users (show)

See Also:

Attachments
Patch with the help doc, and code for enabling the help. (18.02 KB, patch)
2009-05-26 04:46 EDT, Raksha Vasisht CLA 		daniel_megert: review-
Details | Diff
Enable help for Expand With Constructors Dialog (982 bytes, patch)
2009-05-26 05:31 EDT, Raksha Vasisht CLA 		daniel_megert: review-
Details | Diff
Patch with review changes. (24.14 KB, patch)
2009-05-28 07:25 EDT, Raksha Vasisht CLA 		daniel_megert: iplog+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raksha Vasisht CLA 2009-05-26 04:46:48 EDT 
Created attachment 137122 [details]
Patch with the help doc, and code for enabling the help.

Build ID: I20090522-1710

Steps To Reproduce:
(Just putting the doc related requests at one place, so that a single patch can be attached)
1) FiltersDialog of the Call Hierarchy has a help button which leads to an "no
help defined" popup. The dialog sets it's context help to
IJavaHelpContextIds.CALL_HIERARCHY_FILTERS_DIALOG which is never used in the
doc plugins.
There should at least be a little description of the dialog or the help support
in the dialog should be disabled.

2) In addition:
- 'Expand with Constructors' dialog has no help yet, standard workbench window
help is shown

- org.eclipse.jdt.doc.user/reference/views/ref-call-hierarchy.htm: document the
new 'Expand with Constructor' feature

3) The 'Working Set Assignments' dialog has no help yet (standard workbench window
help is shown).

4) The 'Configure Working Set' dialog has no help yet (standard workbench window
help is shown).

More information:
Comment 1 Raksha Vasisht CLA 2009-05-26 04:48:10 EDT 
*** Bug 277302 has been marked as a duplicate of this bug. ***
Comment 2 Raksha Vasisht CLA 2009-05-26 04:48:49 EDT 
*** Bug 277301 has been marked as a duplicate of this bug. ***
Comment 3 Raksha Vasisht CLA 2009-05-26 04:49:20 EDT 
*** Bug 228412 has been marked as a duplicate of this bug. ***
Comment 4 Raksha Vasisht CLA 2009-05-26 05:31:12 EDT 
Created attachment 137125 [details]
Enable help for Expand With Constructors Dialog
Comment 5 Dani Megert CLA 2009-05-27 07:05:48 EDT 
The patches are not good:

1. some help is registered on the parent shell, this is very bad as it changes the help of the whole workbench window.

2. the help context ID that Markus already suggested in ExpandWithConstructorsDialog is good. No need to change it.

3. Call Hierarchy doc: Expand with Constructors command explanation is wrong/incomplete as it describes ony the view menu and not the command in the context menu. We need to describe both. Maybe as 'Expand with Constructors' and 'Expand with Constructors...'

4. call_hierarchy_expand_with_constructors_action_context is missing in contexts_JDT.xml


I did not yet fully review the help text itself. Please provide an updated patch.
Comment 6 Dani Megert CLA 2009-05-27 07:08:06 EDT 
Ah, and please don't forget to update the copyrights (including in HTML files).
Comment 7 Raksha Vasisht CLA 2009-05-28 07:25:32 EDT 
Created attachment 137460 [details]
Patch with review changes.
Comment 8 Dani Megert CLA 2009-05-28 10:04:18 EDT 
Thanks for the updated patch. I've committed it to HEAD with some modifications to the documentation.

Available in builds >= I20090528-2000.
Comment 9 Dani Megert CLA 2009-05-29 04:00:36 EDT 
Verified in I20090528-2000.