Bug 277391 - [plan] [itd] [refactoring] Further issues with Push-in refactoring
Summary: [plan] [itd] [refactoring] Further issues with Push-in refactoring
Status: NEW
Alias: None
Product: AJDT
Classification: Tools
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 2.1.2   Edit
Assignee: AJDT-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 274608
Blocks:
  Show dependency tree
 
Reported: 2009-05-21 16:24 EDT by Andrew Eisenberg CLA
Modified: 2011-09-26 17:30 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Eisenberg CLA 2009-05-21 16:24:17 EDT
The major work for the push in refactoring is complete, but there are still some smaller issues that I should address.

1. visibility. If a pushed-in ITD references some private state of its original aspect, this will show up as an error after the refactoring is complete. It will be up to the user to fix the visibility.

2. declare parents. pushing in declare parents, I use the same infrastructure as that from AspectsConvertingParser to rewrite a class?s declaration line. This means that pushing in a single declare parents into a type will mean that all parents get pushed in. I think this is a rare enough case that we will only fix this if there is a need.

3. fully qualified names. declare parents and annotations will always insert its type using a fully qualified name, rather than using an import statement

4. would be nice to be able to remove specific ITDs from the refactoring by unchecking them in the refactoring wizard.
Comment 1 Andrew Eisenberg CLA 2009-09-30 14:37:50 EDT
Move to the 2.0.2 release.
Comment 2 Andrew Eisenberg CLA 2010-04-28 19:25:46 EDT
Try to solve for 2.1.0.
Comment 3 Andrew Eisenberg CLA 2010-06-16 18:12:13 EDT
Determining what will be tackled for 2.1.1 release.
Comment 4 Andrew Eisenberg CLA 2011-09-26 17:30:56 EDT
#2 is now fixed.  Also, #3 for declare parents is fixed.