Bug 277325 - Adding the I build site gives errors
Summary: Adding the I build site gives errors
Status: RESOLVED WORKSFORME
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: PC Linux-GTK
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2009-05-21 09:35 EDT by Paul Webster CLA
Modified: 2009-09-21 11:08 EDT (History)
6 users (show)

See Also:


Attachments
Error downloading dialog (20.09 KB, image/png)
2009-05-21 09:35 EDT, Paul Webster CLA
no flags Details
Not a repo dialog (17.53 KB, image/png)
2009-05-21 09:36 EDT, Paul Webster CLA
no flags Details
Second not a repo dialog (17.53 KB, image/png)
2009-05-21 09:37 EDT, Paul Webster CLA
no flags Details
Dialog with contents (128.93 KB, image/png)
2009-05-21 09:38 EDT, Paul Webster CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2009-05-21 09:35:31 EDT
Created attachment 136652 [details]
Error downloading dialog

I try and update from http://download.eclipse.org/eclipse/updates/3.5-I-builds

I use the "Add" button to add it, and then p2 tries to load it.  I get 3 different error/failure dialogs, but after 20 to 30 seconds it does populate with entries.

I've attached 3 error pictures (and the populated dialog).

PW
Comment 1 Paul Webster CLA 2009-05-21 09:36:18 EDT
Created attachment 136653 [details]
Not a repo dialog
Comment 2 Paul Webster CLA 2009-05-21 09:37:22 EDT
Created attachment 136654 [details]
Second not a repo dialog
Comment 3 Paul Webster CLA 2009-05-21 09:38:34 EDT
Created attachment 136655 [details]
Dialog with contents

This will show up eventually if you don't touch anything and simply dismiss the problem dialogs.  Try and edit the location or dismiss the install dialog and you'll never know the content is there.

PW
Comment 4 John Arthorne CLA 2009-05-21 09:56:19 EDT
What build were you upgrading from? RC1?
Comment 5 Paul Webster CLA 2009-05-21 10:05:17 EDT
(In reply to comment #4)
> What build were you upgrading from? RC1?

This examples was done on I20090520-2000, but it has been reproducible for me on the builds this week (starting with I20090518-2000)

PW
Comment 6 Andrew Niefer CLA 2009-05-21 10:09:19 EDT
I am also still seeing this on I20090520-2000
Comment 7 John Arthorne CLA 2009-05-21 10:23:08 EDT
Ok, it looks very much like bug 276562, but that was fixed in I20090519-2000.
Comment 8 Paul Webster CLA 2009-05-21 10:29:05 EDT
additional comment:  There are no errors in my error log.

PW
Comment 9 Susan McCourt CLA 2009-05-21 11:34:34 EDT
see also bug 276884.  I'm not sure if these are related or not.  That case involves a silent/unlogged failure but it does not manifest with the error dialog, the UI just stops in its tracks and does not show the site.
Comment 10 John Arthorne CLA 2009-05-21 12:01:04 EDT
From some initial exploration, I wonder if it is just a real transport exception that we're just not handling very well. The site has about 18 builds in it, for a total of about 60MB of metadata, so this is a huge site to load (Kim is going to clean it up today). It could be that a legitimate timeout or transfer failure during this process is happening. When I tested this, I got the error in one out of three attempts, so it isn't consistently reproducible. When I try with a local mirror, I never get the problem.
Comment 11 Susan McCourt CLA 2009-05-21 12:08:58 EDT
The fact that the load completes in the end makes me think the underlying exception is coming from a child of the composite repo, and instead of aggregating it somehow the parent repository is letting it get through?
Comment 12 John Arthorne CLA 2009-05-21 13:21:35 EDT
>The fact that the load completes in the end makes me think the underlying
>exception is coming from a child of the composite repo, and instead of
>aggregating it somehow the parent repository is letting it get through?

Yes, that is possible. CompositeMetadataRepository does catch and log ProvisionException thrown when loading children, but it's possible there is a runtime exception coming through. The I-build site has now been cleaned up and I can't reproduce at all any more.
Comment 13 Pascal Rapicault CLA 2009-09-21 11:08:29 EDT
Closing as worksforme.