Bug 276733 - NewPluginProjectWizard: finish at TemplateListSelectionPage cause NewPluginTemplateWizard runs uninitialized
Summary: NewPluginProjectWizard: finish at TemplateListSelectionPage cause NewPluginTe...
Status: NEW
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows 2000
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: investigate
Depends on:
Blocks:
 
Reported: 2009-05-18 11:23 EDT by Alexey Markevich CLA
Modified: 2023-08-09 13:01 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Markevich CLA 2009-05-18 11:23:12 EDT
I have template for New Plugin Project Wizard. When I go to Templates page and select own template - finish button is enabled. Inside template thete is required option which not filled by default. So if user press finish without going to options page - exceprion occured. If user press next button - isPageComplete method disable finish button and user must fill the parameter.
Comment 1 Curtis Windatt CLA 2009-05-19 11:08:17 EDT
I thought that the API for the templates stated that the option pages must not be required.  The user should be able to select a template and hit finish and not be forced to look at the options.  However, I could not find any reference to this in the API.

To solve this we would need some way for the extension point to tell us whether the options page is required or not.
Comment 2 Alexey Markevich CLA 2009-05-20 02:36:24 EDT
My proposal:
Inside NewPluginProjectWizard.canFinish() add to expression TemplateListSelectionPage.isPageComplete(). And inside TemplateListSelectionPage.isPageComplete() add check for getSelectedWizard().canFinish(). In this case no API/extension point changes required.
Comment 3 Curtis Windatt CLA 2009-05-20 09:38:39 EDT
The problem is that we do not want to load the selected wiard every time we check if the page is complete, as it may require us to load a class from the extension point.
Comment 4 Alexey Markevich CLA 2009-05-21 05:11:42 EDT
But in NewPluginProjectFromTemplateWizard only one template used - can be added to it?
Comment 5 Alexey Markevich CLA 2009-05-21 05:14:47 EDT
Sorry - I didn't check completely - NewPluginProjectFromTemplateWizard works fine.
Comment 6 Alexey Markevich CLA 2009-06-05 09:02:57 EDT
In my class which extends OptionTemplateSection I have
	public boolean isDependentOnParentWizard() {
		return true;
	}
But call (String)super.getValue(KEY_PLUGIN_ID) returns null.
Comment 7 Eclipse Genie CLA 2019-08-28 15:23:58 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 8 Eclipse Genie CLA 2021-08-18 05:55:44 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 9 Eclipse Genie CLA 2023-08-09 13:01:53 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.