Bug 276729 - [ds tooling] Textboxes missing border on linux
Summary: [ds tooling] Textboxes missing border on linux
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.5 RC2   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2009-05-18 11:18 EDT by Ian Bull CLA
Modified: 2009-05-20 10:01 EDT (History)
2 users (show)

See Also:
curtis.windatt.public: review+
darin.eclipse: review+

Attachments
Example of a dialog in need of love (21.24 KB, image/png)
2009-05-18 11:18 EDT, Ian Bull CLA 		no flags Details
Adds borders to the Referenced Services Dialog (755 bytes, patch)
2009-05-18 17:10 EDT, Ian Bull CLA 		no flags Details | Diff
org.eclipse.pde.ds.ui.patch (2.42 KB, patch)
2009-05-18 17:14 EDT, Chris Aniszczyk CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Bull CLA 2009-05-18 11:18:46 EDT 
Created attachment 136198 [details]
Example of a dialog in need of love

The text boxes on some of the DS dialogs are missing borders.  Also some labels are blue while others are black.
Comment 1 Ian Bull CLA 2009-05-18 11:20:46 EDT 
I'll take a stab at this.
Comment 2 Ian Bull CLA 2009-05-18 17:10:06 EDT 
Created attachment 136229 [details]
Adds borders to the Referenced Services Dialog
Comment 3 Chris Aniszczyk CLA 2009-05-18 17:14:59 EDT 
Created attachment 136230 [details]
org.eclipse.pde.ds.ui.patch

There were two places we forgot to add borders:

- properties dialog
- reference dialog
Comment 4 Chris Aniszczyk CLA 2009-05-18 17:15:31 EDT 
The fix is very low risk imho.
Comment 5 Curtis Windatt CLA 2009-05-19 10:29:50 EDT 
+1 I am ok with this for RC2.

Though I must ask, why does DS use the forms look in it's dialogs?  We use a normal dialog style to add everything but then use the forms look when editing.
Comment 6 Ian Bull CLA 2009-05-19 11:32:47 EDT 
(In reply to comment #5)

> Though I must ask, why does DS use the forms look in it's dialogs?  We use a
> normal dialog style to add everything but then use the forms look when editing.
> 

I have to agree.  When testing these dialogs they just felt "odd".
Comment 7 Darin Wright CLA 2009-05-19 17:24:42 EDT 
looks ok.
Comment 8 Chris Aniszczyk CLA 2009-05-20 02:08:15 EDT 
done.

> 20090520

I don't like the forms dialogs either, but this is the way things came to be from the initial contribution. We can revisit the UI in 3.6
Comment 9 Curtis Windatt CLA 2009-05-20 10:01:50 EDT 
Verified with two reviewers.