Bug 276714 - Enhance "Convert to Plug-in Projects" to work better with non-ASCII chars
Summary: Enhance "Convert to Plug-in Projects" to work better with non-ASCII chars
Status: CLOSED WONTFIX
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2009-05-18 10:31 EDT by Szymon Brandys CLA
Modified: 2019-09-09 02:26 EDT (History)
5 users (show)

See Also:


Attachments
Screenshot illustrating the issue (86.82 KB, image/jpeg)
2009-05-18 10:32 EDT, Szymon Brandys CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2009-05-18 10:31:18 EDT
3.5RC1

Steps:
1) Create a general project using at least one non-ASCII character
2) Open the project context menu and use "Configure > Convert to Plug-in Projects"
3) All necessary files are added, however there are problems with non-ASCII characters in MANIFEST.MF

See the attached screenshot.
Comment 1 Szymon Brandys CLA 2009-05-18 10:32:23 EDT
Created attachment 136193 [details]
Screenshot illustrating the issue
Comment 2 Chris Aniszczyk CLA 2009-05-18 10:35:40 EDT
The reason this is done is because on conversion, we generate a BSN. The BSN is only ASCII characters.

I propose close WORKSFORME unless you have an enhancement or bug request :)
Comment 3 Szymon Brandys CLA 2009-05-18 11:11:57 EDT
What is usually done is such cases, non-ASCII characters are replaced with suitable ASCII characters. In the case from the screenshot it would be "wozek". Maybe someone from the community would like to address the issue :-)
Comment 4 Chris Aniszczyk CLA 2009-05-18 11:13:18 EDT
Is there something in ICU4J that does that? Or somewhere in Eclipse code that we could reuse?
Comment 5 Szymon Brandys CLA 2009-05-18 11:30:53 EDT
I was not precise. I've seen this in some other apps, not in Eclipse itself. About ICU4J, I think that someone from the UI team should be asked. Maybe Kevin.
Comment 6 Kevin McGuire CLA 2009-05-19 10:34:59 EDT
Paul is our ICU4J expert (or at least knows more than me).
Comment 7 Paul Webster CLA 2009-05-20 08:19:34 EDT
(In reply to comment #6)
> Paul is our ICU4J expert (or at least knows more than me).

I've asked the ICU guys, I'll post when I know more.

Dani, is there anything in text that does what they're asking?

Or more generally, do we have an action that can convert one encoding to another.  I'm always getting hit by (c) or ae being entered on windows and preventing my files from compiling on linux because they can't be read by UTF-8, and I haven't been able to find a good way to "cleanse" the files (aside from finding the offending chars and using sed 's//g' :-)

PW
Comment 8 Dani Megert CLA 2009-05-20 08:29:19 EDT
>we generate a BSN
BSN? Is this some standard?
Comment 9 Dani Megert CLA 2009-05-20 08:59:42 EDT
I wonder how you can say "WORKSFORME". For languages like Hebrew the convert-functionality is simply always broken.

Not sure what support you expect from ICU or Text: the name is correctly available, the manifest.mf is UTF-8 and the PDE editor supports non-ASCII hence you only need to get the conversion right.
Comment 10 Nitin Dahyabhai CLA 2009-05-20 09:51:16 EDT
(In reply to comment #8)
> >we generate a BSN
> BSN? Is this some standard?

Bundle Symbolic Name?  I'd expect that as long as the non-ASCII characters can be expressed in UTF-8, it would work fine.

Comment 11 Paul Webster CLA 2009-06-01 14:23:57 EDT
(In reply to comment #3)
> What is usually done is such cases, non-ASCII characters are replaced with
> suitable ASCII characters. In the case from the screenshot it would be "wozek".
> Maybe someone from the community would like to address the issue :-)
> 

While no longer relevant, ICU contains com.ibm.icu.text.Transliterator which can do this (when configured with the correct rules).

PW
Comment 12 Eclipse Webmaster CLA 2019-09-06 16:07:44 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 13 Julian Honnen CLA 2019-09-09 02:26:05 EDT
Please remove the stalebug flag, if this issue is still relevant and can be reproduced on the latest release.