Bug 275244 - org.eclipse.jdt.internal.compiler.util.Util.getZipEntryByteContent(ZipEntry, ZipFile) should use BufferedInputStream
Summary: org.eclipse.jdt.internal.compiler.util.Util.getZipEntryByteContent(ZipEntry, ...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 RC1   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2009-05-06 21:34 EDT by Olivier Thomann CLA
Modified: 2009-05-14 11:32 EDT (History)
1 user (show)

See Also:
david_audel: review+

Attachments
Proposed fix (1.05 KB, patch)
2009-05-06 21:35 EDT, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2009-05-06 21:34:08 EDT 
This method should use a BufferedInputStream.
Comment 1 Olivier Thomann CLA 2009-05-06 21:35:32 EDT 
Created attachment 134723 [details]
Proposed fix
Comment 2 Olivier Thomann CLA 2009-05-06 21:35:56 EDT 
David, please review.
Comment 3 David Audel CLA 2009-05-07 05:01:28 EDT 
Patch looks good.
Comment 4 Olivier Thomann CLA 2009-05-07 09:13:24 EDT 
Released for 3.5RC1.
Code verification is required for this bug.
Comment 5 Kent Johnson CLA 2009-05-14 11:32:26 EDT 
Verified for 3.5RC1 using I20090513-2000