Bug 275180 - A missing semicolon in an aspect causes the file to silently fail
Summary: A missing semicolon in an aspect causes the file to silently fail
Status: REOPENED
Alias: None
Product: AJDT
Classification: Tools
Component: UI (show other bugs)
Version: 1.6.3   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: AJDT-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-06 12:48 EDT by Kendall CLA
Modified: 2010-04-28 19:20 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kendall CLA 2009-05-06 12:48:18 EDT
An aspect, Bar.aj, created with only the following code fails to build in eclipse.

public aspect Bar {

  private static final String junk = "...."
}

There is no error reported, and any other code added to the aspect, no matter how correct, does not get applied.  However, there is no indication in the problems view or the editor that anything has gone wrong.  This is most annoying, as this can be missed in a quick search of a larger file.
Comment 1 Andrew Eisenberg CLA 2009-05-06 12:55:07 EDT
From my message on the mailing list:

It almost sounds like the compiler isn't running.

Are you seeing this for full builds or incremental only?

When you open the AJDT Event trace view (and select all filters) and make an edit/save in the file, what do you see?

I have just tried this in my own workspace and I am seeing the expected syntax error in the editor and problems view.  So, I think something else is going on.
Comment 2 Andrew Eisenberg CLA 2009-05-06 12:57:38 EDT
A couple of more questions:

Is Bar.aj the only source file in the project?

You also might want to update to the latest dev version.  We have fixed quite a few bugs since 1.6.3.  This may be one of them.

http://download.eclipse.org/tools/ajdt/34/dev/update
Comment 3 Kendall CLA 2009-05-06 13:05:56 EDT
Yes, this is the only file in the project.  However, this happened with a larger file in a larger project as well.

I posted build logs on the mailing list, but for reference:
Making a change and doing a build, I get the following in my log:

9:58:0 Preparing for build: planning to be an incremental build
9:58:0 Starting incremental compilation loop 1 of possibly 5
9:58:0 AJC: compiling source files
9:58:0 Timer event: 109ms: Time to first compiled message
9:58:0 AJC: compiled: C:\kmerrima\Java_Dev\Java\AspectBreak\src\Bar.aj
9:58:0 AspectJ reports build successful, build was: INCREMENTAL
9:58:0 AJDE Callback: finish. Was full build: false

Cleaning the project and doing a build, I get this:

9:59:52 Preparing for build: not going to be incremental because no
successful previous full build
9:59:52 AJC: compiling source files
9:59:52 Timer event: 110ms: Time to first compiled message
9:59:52 AJC: compiled: C:\kmerrima\Java_Dev\Java\AspectBreak\src\Bar.aj
9:59:52 AspectJ reports build successful, build was: FULL
9:59:52 AJDE Callback: finish. Was full build: true

Unfortunately, I can't update to the latest release version, due to a regression bug in that one.  As for the dev version, that could be possible.  I'll try it later today, hopefully.
Comment 4 Andrew Eisenberg CLA 2009-05-06 13:10:30 EDT
(In reply to comment #3)
> Unfortunately, I can't update to the latest release version, due to a
> regression bug in that one.  As for the dev version, that could be possible. 
> I'll try it later today, hopefully.
> 
Please describe the regression.
Comment 5 Kendall CLA 2009-05-06 14:44:13 EDT
(In reply to comment #4)
> (In reply to comment #3)
> > Unfortunately, I can't update to the latest release version, due to a
> > regression bug in that one.  As for the dev version, that could be possible. 
> > I'll try it later today, hopefully.
> > 
> Please describe the regression.
> 
It is a regression that is fixed in dev, related to an exception when there are multiple projects that have the same classpath.
Comment 6 Andrew Eisenberg CLA 2009-05-06 18:28:38 EDT
(In reply to comment #5)
> It is a regression that is fixed in dev, related to an exception when there are
> multiple projects that have the same classpath.
> 
Is there a bug open for this?  I am not aware of fixing this problem.
Comment 7 Kendall CLA 2009-05-07 16:09:00 EDT
(In reply to comment #6)
> (In reply to comment #5)
> > It is a regression that is fixed in dev, related to an exception when there are
> > multiple projects that have the same classpath.
> > 
> Is there a bug open for this?  I am not aware of fixing this problem.
> 
Bug #269902
Comment 8 Kendall CLA 2009-05-07 16:19:32 EDT
Apparently, I'm crazy, as no one else here can reproduce this either.  I still think there is something wrong, but until I can reproduce it consistently on machines other then my own, I guess this issue can be closed.  I'll reopen it if I can get it to happen more consistently.
Comment 9 Kendall CLA 2009-05-08 15:51:25 EDT
Ok, I found out that the bug happens only when jdt weaving is disabled.  If you want to reopen the bug, it is still a bug.
Comment 10 Andrew Eisenberg CLA 2009-05-08 15:57:53 EDT
Reopening bug, but marking as low severity because we recommend running with the weaving service enabled.
Comment 11 Andrew Eisenberg CLA 2010-04-28 19:20:19 EDT
No longer slated for the next release.