Bug 27462 - [startup] SearchPlugin is loaded when Java plug-in gets loaded
Summary: [startup] SearchPlugin is loaded when Java plug-in gets loaded
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.1 M4   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
: 27362 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-11-30 19:39 EST by Erich Gamma CLA
Modified: 2002-12-03 10:28 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Erich Gamma CLA 2002-11-30 19:39:59 EST 
The Java UI plugin eagerly activates the Search plugin.

There are 2 reason:
1) ISearchPageScore adapter that is registered
2) fSearchResultViewEntryAdapterFactory

we should investigate whether we can reduce this plugin activation.
Comment 1 Dani Megert CLA 2002-12-02 06:26:27 EST 
The first item can only be fixed by throwing away the functionality to detect
the correct search page. I don't recommend to do so.

I can only find the second item/reference inside Search plug-in. This code does
not get executed until Search plug-in has already been forced to load. Please
add more context.
Comment 2 Dani Megert CLA 2002-12-02 06:44:21 EST 
*** Bug 27362 has been marked as a duplicate of this bug. ***
Comment 3 Dani Megert CLA 2002-12-02 06:49:45 EST 
Changed summary.
Activating the Java Plugin activates the Search plug-in (it's not only the
switch to Java perspective scenario).

In the duplicate report it's reported that there are no resources yet. Even
though we could wait with registering some adapters until there is at least one
resource I don't think this would be a good idea.
Comment 4 Dani Megert CLA 2002-12-03 10:28:54 EST 
Fixed by
- defering the creation of the JavaSearchPageComputer until the Search plug-in
is activated
- moving instanceof checks to SearchUtil and first test if Search plug-in is
activated

NOTE:
1) This solution is only valid because Search doesn't use the adapters until the
Search plug-in is actually activated.
2)

Available in builds > I20021203