Community
Participate
Working Groups
Right now on the locations tab of the target editor/wizard you only get single selection. There is a removeall button, but out of habit I always hit Ctrl-A, Del to remove things (and sometimes I want to remove one or two specific containers). Adding this should be an easy polish item, we just have to be careful in the button handling/enablement.
Created attachment 134771 [details] Patch Added SWT.MULTI to the tree. This enabled Ctrl + A automatically.
Thanks Ankur. Applied patch. Curtis, please verify.
Reopening 1) Ctrl-A works, but the delete key doesn't. 2) Hitting the remove button with a multi-selection only removes the first selected entry. 3) There is no need for a remove all button 4) Remove button enablement is broken, it only checks part of what is selected. I only found this noticeable when I had error statuses showing as children of the locations. Note that the edit button's enablement has the same problems. The enablement code assumed that the tree was single selection.
Oops, I was testing the wrong page... I was testing the pref page not the locations tab... My mistake.
Isn't this more of an enhancement?
(In reply to comment #5) > Isn't this more of an enhancement? > I would describe this as a polish bug. On the preference page and elsewhere in the IDE we support multi-selection. This tree originally had a lot of mixed content so it was simpler to go with single selection. Now this page primarily displays just locations and any other items in the tree can be ignored (they cannot be edited or removed). This is not a large fix, though it is more than one line :)
I reverted the MULTI setting since the fix was incomplete.
RC1 is closing soon... are we going to punt on this?
Yes, there are other things to worry about for 3.5.
Created attachment 135210 [details] Patch with KeyListner This patch has multi selection, ctl+a for select all, del key for remove, all selected remove using del ley or remove button click. However, I feel its incomplete without Undo and Redo functionality on target editor. But that is bigger chunk of work and has to go in 3.6 now.
Ankur, if you want to look into undo/redo support for the TargetLocationGroup, cool, if not we will put this in for M1.
Fixed in HEAD, see TargetLocationGroup.java Had to redo the fix as the patch resulted in the tree being refreshed multiple times and didn't handle multi selection very well.
Verified.
