Bug 273177 - [publisher] No metadata generated for a product license
Summary: [publisher] No metadata generated for a product license
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Ian Bull CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
: 229880 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-04-21 23:56 EDT by Ian Bull CLA
Modified: 2009-04-27 09:52 EDT (History)
4 users (show)

See Also:

Attachments
Adds the license section to the product parser (6.89 KB, patch)
2009-04-23 18:00 EDT, Ian Bull CLA 		no flags Details | Diff
publisher patch for product license (21.59 KB, patch)
2009-04-24 18:26 EDT, Ian Bull CLA 		pascal: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Bull CLA 2009-04-21 23:56:46 EDT 
The publisher currently doesn't parse or generate metadata for the license information in a .product file.  Should it?  Do products have licenses, or should we just use the licenses of the bundles / features that constitute the project?
Comment 1 Ian Bull CLA 2009-04-22 00:03:33 EDT 
Actually, it appears PDE export doesn't do anything with this either (not sure if it should).  For example, I just created a product, gave it a GPL license, exported it and rgreped the dir for GPL. nothing.

Chris, do you have thoughts on this?
Comment 2 Chris Aniszczyk CLA 2009-04-22 01:19:33 EDT 
The publisher should take care of this imho.

A product can have an all encompassing license.
Comment 3 Ian Bull CLA 2009-04-22 11:29:39 EDT 
I agree the publisher should take care of this when generating IUs.  Is this license only meant for IUs though?
Comment 4 Pascal Rapicault CLA 2009-04-22 12:27:11 EDT 
*** Bug 229880 has been marked as a duplicate of this bug. ***
Comment 5 Pascal Rapicault CLA 2009-04-22 23:12:55 EDT 
Much like the license of the feature ends up in the IU, this license text should end up in the product IU. This would be a nice to have functionality.
Comment 6 Ian Bull CLA 2009-04-23 18:00:58 EDT 
Created attachment 133033 [details]
Adds the license section to the product parser

This patch adds the parsing of licenses to the product parser. I still have to put this in the product publishing action.
Comment 7 Ian Bull CLA 2009-04-24 18:26:46 EDT 
Created attachment 133204 [details]
publisher patch for product license

This patch adds the product license support to the publisher.  This is done through ILicenseAdvice.
Comment 8 Ian Bull CLA 2009-04-24 22:34:29 EDT 
Since the license doesn't actually appear in the running product, it's not needed in the plugin.
Comment 9 Pascal Rapicault CLA 2009-04-27 09:51:48 EDT 
Fixed in HEAD.