Comment 1 Nick Sandonato 2009-04-20 16:40:44 EDT

There is one string that would need to be translated in this patch.

Comment 2 Nitin Dahyabhai 2009-04-22 11:44:41 EDT

Looks good.  Adding PMC for string approval.

The solution for this problem is to offer to automatically close quoted attribute values when typing, which saves us from potentially reparsing the remainder of the file to find a matching quote.  As with all of the other cases where we automatically insert content that the user hasn't keyed in, it should still be a user-visible preference (which we're going to have enabled by default).

Comment 3 Nick Sandonato 2009-05-06 14:09:54 EDT

Created attachment 134661 [details]
patch without preference

Updated patch to exclude the user preference to eliminate the need for a translated string.

Comment 4 Nick Sandonato 2009-05-06 14:11:16 EDT

Nitin, can you review this again? I've stripped out the new for user preferences.

Comment 5 Nitin Dahyabhai 2009-05-06 14:42:02 EDT

Approved.

Comment 6 Nick Sandonato 2009-05-06 16:33:18 EDT

Released.

Comment 7 David Mansfield 2009-06-09 10:58:21 EDT

this change breaks the expected user experience when typing attributes in the html/xml/jsp editors.  when the closing quote is typed, the cursor doesn't skip past it, so the user cannot "just type" what he/she wants.  this is incredibly frustrating.

if you think this should be opened as a new/separate bug then that's ok, i can do it.

(this is with the latest updates applied as of yesterday)

Comment 8 Nick Sandonato 2009-06-09 13:13:01 EDT

I can see your point. Could you open an enhancement request for ignoring a closing quote and skipping past it and reference this bug?