Bug 272954 - [planner] updatesFor should return a Queryable
Summary: [planner] updatesFor should return a Queryable
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.6 M6   Edit
Assignee: Pascal Rapicault CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on: 219122
Blocks:
  Show dependency tree
 
Reported: 2009-04-20 14:43 EDT by Pascal Rapicault CLA
Modified: 2010-02-26 12:36 EST (History)
1 user (show)

See Also:

Attachments
Patch (11.12 KB, patch)
2009-04-21 13:13 EDT, Ian Bull CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2009-04-20 14:43:37 EDT 
To be consistent with other places of the code, the method updatesFor on IPlanner should return a IQueryable
Comment 1 Ian Bull CLA 2009-04-21 13:13:55 EDT 
Created attachment 132631 [details]
Patch

Here is a patch that uses an IQueryable instead of IInstallableUnit array. I found 4 calls to updatesFor and I changed these to now Query the Queryable for all IUs.

I'm not sure if this is urgent for 3.5.  If you want me to continue with this (write more tests etc...) let me know.
Comment 2 Pascal Rapicault CLA 2009-04-21 19:19:59 EDT 
Thanks for the patch. However it will not be released for 3.5 as this is (despite the appropriate severity) an enhancement. We will look into this  in 3.6 as we revisit the mechanism by which updates are being found.
Comment 3 Pascal Rapicault CLA 2010-02-26 12:36:24 EST 
I fixed this in HEAD, but I did not use the patch because it was out dated.