Bug 272717 - [terminal] Detect CheckPII errors in terminal code (in RSE runtime zip file)
Summary: [terminal] Detect CheckPII errors in terminal code (in RSE runtime zip file)
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: Terminal (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.1 M7   Edit
Assignee: Martin Oberhuber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: PII
Depends on:
Blocks:
 
Reported: 2009-04-17 12:04 EDT by Xuan Chen CLA
Modified: 2009-04-20 11:49 EDT (History)
0 users

See Also:


Attachments
patch adding NLS_MESSAGEFORMAT comments (3.99 KB, patch)
2009-04-20 06:09 EDT, Martin Oberhuber CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xuan Chen CLA 2009-04-17 12:04:57 EDT
Those properties files has check PII errors.  We need to fix them in order to send to translation.  Please fix them as soon as possible.  Thanks.

plugin "org.eclipse.tm.terminal":
plugin.properties 
ActionMessages.properties
TerminalMesages.properties

The reason is: 
922   Unknown single quote handling for this file.  Special NLS_MESSAGEFORMAT comment must be added.     

Guide line for fixing:
. Add this comment to the start of the file
# NLS_ENCODING=UTF-8
						
. Add one of the following comments to the file to indicate what type of single quote handling should be used:

# NLS_MESSAGEFORMAT_ALL 
# NLS_MESSAGEFORMAT_NONE
# NLS_MESSAGEFORMAT_VAR

Choose which comment to use based on this criteria:
NLS_MESSAGEFORMAT_ALL 	Each string is assumed to be processed by the java.text.MessageFormat class (single quote must be coded as 2 consecutive single quotes '').
NLS_MESSAGEFORMAT_NONE 	All strings are assumed to NOT be processed by the java.text.MessageFormat class (single quote must be coded as 1 single quote ').
NLS_MESSAGEFORMAT_VAR 	Strings which contain replacement variables are processed by the MessageFormat class (single quote must be coded as 2 consecutive single quotes ''). Strings which do NOT contain replacement variables are NOT processed by the MessageFormat class (single quote must be coded as 1 single quote ').
Comment 1 Martin Oberhuber CLA 2009-04-20 06:09:15 EDT
cannot see why this is major -- there is no single quote in the referenced property files, so there is no loss of functionality.
Comment 2 Martin Oberhuber CLA 2009-04-20 06:09:48 EDT
Created attachment 132390 [details]
patch adding NLS_MESSAGEFORMAT comments
Comment 3 Martin Oberhuber CLA 2009-04-20 06:13:18 EDT
Committed and released:
[272717] Add NLS_MESSAGEFORMAT comments to Terminal properties files for Chkpii
Comment 4 Xuan Chen CLA 2009-04-20 11:49:00 EDT
Thanks for the fixes, Martin.