Bug 272614 - Preferences: Double entries for Occurrences and Override indicators
Summary: Preferences: Double entries for Occurrences and Override indicators
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: General (show other bugs)
Version: 3.0.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0.5   Edit
Assignee: Chris Jaun CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords: contributed
: 279639 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-04-16 22:36 EDT by Karsten Wutzke CLA
Modified: 2010-03-03 11:14 EST (History)
3 users (show)

See Also:
thatnitind: review+


Attachments
Updates the plugin.xml to use unique key values (5.48 KB, patch)
2009-04-17 11:11 EDT, Chris Jaun CLA
thatnitind: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Karsten Wutzke CLA 2009-04-16 22:36:15 EDT
Build ID: M20090211-1700

Steps To Reproduce:
1. Hit the preferences under "Window" -> "Preferences".
2. Hit "General" -> "Editors" -> "Text Editors" -> "Annotations".

I have *two* things here:

1. First in the annotation types box to the right, there are double entries:

Occurrences (org.eclipse.jdt.ui.occurrences)
Occurrences (org.eclipse.wst.jsdt.ui.occurrences)

and

Override indicators (org.eclipse.jdt.ui.overrideIndicators)
Override indicators (org.eclipse.wst.jsdt.ui.overrideIndicators)

Both double entries are linked to each other, both changing each other. This probably isn't supposed that way!

2. Secondly (I only tried with the occurrences so far) when changing the color and then pressing OK *doesn't* change the setting immediately (OK closing prefs window), but only when restarting Eclipse. Setting the single-entry "Write occurrences" at the end of that list immediately changes when pressing OK.

Maybe this boils down to the double entries somehow conflicting with each other as described above...?

More information:

Maybe my classification isn't right. It's all about preferences.
Comment 1 Chris Jaun CLA 2009-04-17 11:11:43 EDT
Created attachment 132254 [details]
Updates the plugin.xml to use unique key values
Comment 2 Chris Jaun CLA 2009-04-17 11:12:07 EDT
Should be fixed in 3.0.5 and 3.1.
Comment 3 Karsten Wutzke CLA 2009-04-19 07:06:16 EDT
Sorry how do I fix this with the attached file?
Comment 4 Chris Jaun CLA 2009-04-20 09:51:33 EDT
The attached patch will only work if you are using JSDT source and building it yourself. 

If you are just using a WTP that you downloaded from the eclipse.org then I would suggest waiting until the patch goes into a build and picking that build up.

If you want instructions on how to apply the source patch let me know.
Comment 5 Nitin Dahyabhai CLA 2009-04-23 02:38:50 EDT
Applied, thanks, Chris.  It's a similar problem in bug 266680, but that one requires more than plugin.xml changes.
Comment 6 Chris Jaun CLA 2009-06-12 15:47:32 EDT
*** Bug 279639 has been marked as a duplicate of this bug. ***