Bug 272578 - Loading profile preference node loads profile
Summary: Loading profile preference node loads profile
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2009-04-16 16:45 EDT by John Arthorne CLA
Modified: 2009-04-17 15:40 EDT (History)
2 users (show)

See Also:

Attachments
Profiler output (2.90 KB, text/plain)
2009-04-16 16:48 EDT, John Arthorne CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2009-04-16 16:45:51 EDT 
Loading the profile preference node is currently loading the full-blown IProfile object from the profile registry. This is expensive and unnecessary.
Comment 1 John Arthorne CLA 2009-04-16 16:48:19 EDT 
Created attachment 132135 [details]
Profiler output
Comment 2 Susan McCourt CLA 2009-04-16 18:23:11 EDT 
I'm glad you brought this up, because in bug 222498 comment 4, we determinded that we have to load those preferences in bundle startup code, which means the expensive profile code is being run in startup.  :-(
Comment 3 John Arthorne CLA 2009-04-17 14:56:04 EDT 
Yes, this is why I noticed it. I was profiling the automated "UI startup" performance test from the latest nightly build and noticed a big hit here.
Comment 4 John Arthorne CLA 2009-04-17 15:40:05 EDT 
Fixed in HEAD. This required adding a new method IProfileRegistry.contains to check for existence of a profile on disk without actually loading it.