Community
Participate
Working Groups
+++ This bug was initially created as a clone of Bug #271198 +++
Created attachment 131864 [details] o.e.pde.ui patch Here is an initial code drop for the changes to the PDE Export Wizard to support categories. I will continue working on this. This drop just includes the new buttons so a user can choose the category file.
Created attachment 131865 [details] mylyn/context/zip
Created attachment 131878 [details] o.e.pde.ui updated patch Here is an updated patch. This finishes the UI work, however, this is not tied to PDE Build yet (i.e. it doesn't process the flags when the wizard is done). I have to make a changed to the publisher and then PDE build before we can finish this.
Created attachment 131879 [details] mylyn/context/zip
What bug does this depend on in p2 publisher land Ian?
Bug 264567 is the publisher bug. Not sure what changes are required to build yet. Currently you specify a site.xml by pointing to a dir that contains a file called site.xml. Since the category file can have any name, we need to point directly to a file for this.
Ian, for the UI, we can be smart about the browse functionality. We can filter based on valid content types. For example, we can have a method like boolean isCategoryFile(IFile candidate) IContentDescription description = candidate.getContentDescription(); if (description == null) return false; IContentType type = description.getContentType(); return "org.eclipse.pde.categoryManifest".equals(type.getId()); What do you think?
I've updated the dependencies. We really only need to have bug 272362 in for 3.5. The only thing left after this is changes to PDE Build.
Created attachment 132296 [details] o.e.pde.ui patch Here is an updated patch that finishes the UI work for category export. A new PDE core / build patch is on its way
where's the core/build patch? It would be great to get this in for the next i-build
Chris, It's on Bug 272362 waiting to be reviewed.
Do we want to enable this only for features or for just normal plug-in export?
(In reply to comment #12) > Do we want to enable this only for features or for just normal plug-in export? My understanding is that it still does not work for plug-ins since the "site.xml" format has been used (which does not allow to add plug-ins to categories). So, I think it's features only (please correct me if wrong, Ian).
(In reply to comment #13) > My understanding is that it still does not work for plug-ins since the > "site.xml" format has been used (which does not allow to add plug-ins to > categories). So, I think it's features only (please correct me if wrong, Ian). > Darin's right, we simply used the site.xml format (for now). Going forward, I think we will evolve this format (or simply change it) and then we will enable plug-in export. I don't think that should happen for 3.5.
Is there any documentation on this yet. A wiki page?
Looking at this patch, I think it would be more helpful if the browse button searched for category.xml files in the workspace. Since users can only export from their workspace and the category editor is only available in the workspace, we should not send users to browse their hard drives.
(In reply to comment #16) > Looking at this patch, I think it would be more helpful if the browse button > searched for category.xml files in the workspace. Since users can only export > from their workspace and the category editor is only available in the > workspace, we should not send users to browse their hard drives. > +1. Do you want me to create a new patch, or should we tag that as polish for 3.5?
If you have the opportunity to make another patch go for it, as it doesn't look like the p2 changes are going to be put in today.
Created attachment 133232 [details] Updated patch This patch checks that the category file exists and passes a URI instead of a path.
Created attachment 133233 [details] PDE UI and PDE Core patch Andrew just informed me that the PDE Core changes should be grouped with the PDE UI changes (I had them grouped with build before). This patch is the same UI patch + the few small changes needed to PDE Core.
done. > 20090425 I'll open another bug to improve the browse to only search your workspace.
