Bug 271792 - Make sure that the comparator errors are reported on the actual jar
Summary: Make sure that the comparator errors are reported on the actual jar
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Matthew Piggott CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2009-04-09 11:03 EDT by Pascal Rapicault CLA
Modified: 2009-04-17 10:40 EDT (History)
1 user (show)

See Also:

Attachments
Changes to comparator error messages (10.05 KB, patch)
2009-04-14 14:58 EDT, Matthew Piggott CLA 		no flags Details | Diff
Comparator (10.08 KB, patch)
2009-04-14 15:01 EDT, Matthew Piggott CLA 		pascal: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2009-04-09 11:03:26 EDT 
Matt thinks he saw the comparator reporting errors on the temp files and not on the actual jar file.
If this is the case we need to fix this to provide a useful message to the user.
Comment 1 Matthew Piggott CLA 2009-04-14 14:58:08 EDT 
Created attachment 131827 [details]
Changes to comparator error messages

I've attempted to improve the clarity of error messages from the MD5ArtifactComparator and JarComparator.

An example from JarComparator:
Old: 
Difference: sourceartifact1234.jar contains 3 files and destinationartifact1234.jar contains 4 files

New: 
Difference in [canonical: binary,testKeyId,1.2.3]: http://repo1/ contains 3 files and http://repo2/ contains 4 files.
Comment 2 Matthew Piggott CLA 2009-04-14 15:01:19 EDT 
Created attachment 131828 [details]
Comparator

Small fix
Comment 3 Pascal Rapicault CLA 2009-04-17 10:34:05 EDT 
Patch released in HEAD.