Bug 271504 - [Editor] Dialogs missing keyboard mnemonics
Summary: [Editor] Dialogs missing keyboard mnemonics
Status: CLOSED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.xsd (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.2 M6   Edit
Assignee: Wini Mark CLA
QA Contact: Valentin Baciu CLA
URL:
Whiteboard:
Keywords: accessibility, plan
Depends on:
Blocks:
 
Reported: 2009-04-07 14:24 EDT by Mike Oetlinger CLA
Modified: 2010-06-16 13:58 EDT (History)
1 user (show)

See Also:

Attachments
Patch to add the mnemonic (5.01 KB, patch)
2009-12-31 15:04 EST, Wini Mark CLA 		valentinbaciu: iplog+
Details | Diff
Add mnemonic in context menu (5.76 KB, patch)
2010-01-15 15:36 EST, Wini Mark CLA 		valentinbaciu: iplog+
Details | Diff
New patch to fix more missing mnemonic (10.48 KB, patch)
2010-03-04 21:56 EST, Wini Mark CLA 		valentinbaciu: iplog+
Details | Diff
Enhanced patch (60.47 KB, patch)
2010-03-06 00:43 EST, Valentin Baciu CLA 		valentinbaciu: iplog+
Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Oetlinger CLA 2009-04-07 14:24:05 EDT 
Build ID: I20090313-0100

Steps To Reproduce:
The following dialogs are either completely or partially lacking keyboard mnemonics:

- Set Type
- Add Category
- Add Extension Components
- New Type
- Edit Schema Information


More information:
Other places missing mnemonics:

- Properties view for XSD objects
- Context menus for XSD objects
Comment 1 Wini Mark CLA 2009-12-31 15:04:27 EST 
Created attachment 155158 [details]
Patch to add the mnemonic
Comment 2 Wini Mark CLA 2010-01-15 15:36:03 EST 
Created attachment 156274 [details]
Add mnemonic in context menu
Comment 3 Wini Mark CLA 2010-03-04 21:56:35 EST 
Created attachment 161063 [details]
New patch to fix more missing mnemonic
Comment 4 Valentin Baciu CLA 2010-03-05 20:12:47 EST 
Thank you Wini, I am reviewing the patch and will attach an enhanced version shortly.
Comment 5 Valentin Baciu CLA 2010-03-06 00:43:09 EST 
Created attachment 161216 [details]
Enhanced patch

The previous patch missed mnemonics in quite a few places. I've also changed some of the original choices for mnemonics for better readability.
One of the challenges was the fact that the Actions and Commands share labels. This means changing the action label changes the string displayed in the undo / redo menu. In the interest of time I chose to strip the ampersand programatically in the commands instead of duplicating all the strings.
Comment 6 Valentin Baciu CLA 2010-03-06 00:44:31 EST 
I have committed all changes but not released yet.

Wini, please test well and let me know if I've missed anything. You may have to adjust the patch for the refactoring menu extensibility because I've already added mnemonics for the refactoring pop-up menu and it's child menu items.
Comment 7 Valentin Baciu CLA 2010-03-06 21:46:39 EST 
Changes released to WTP 3.2 M6 builds > v201003070245 UTC.
Comment 8 Valentin Baciu CLA 2010-06-16 13:58:37 EDT 
Closing.