Bug 270481 - [Editor] Cannot expand a binding in WSDL editor design view via keyboard
Summary: [Editor] Cannot expand a binding in WSDL editor design view via keyboard
Status: CLOSED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: wst.wsdl (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 M7   Edit
Assignee: Raymond Lai CLA
QA Contact: Valentin Baciu CLA
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2009-03-30 12:51 EDT by Mike Oetlinger CLA
Modified: 2009-05-04 13:28 EDT (History)
1 user (show)

See Also:
valentinbaciu: review+

Attachments
Patch to use "Enter" to simulate a mouse double click for accessibililty (1.85 KB, patch)
2009-04-06 09:28 EDT, Raymond Lai CLA 		valentinbaciu: iplog+
Details | Diff
New patch to simulate double click with "Enter" key for accessibility (1.91 KB, patch)
2009-04-06 09:38 EDT, Raymond Lai CLA 		valentinbaciu: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Oetlinger CLA 2009-03-30 12:51:16 EDT 
Build ID: I20090313-0100

Steps To Reproduce:
1. Open a WSDL file.
2. Add a new binding to it.
3. You cannot expand the binding by keyboard like you would with the mouse (i.e. double click).


More information:
Comment 1 Raymond Lai CLA 2009-04-06 09:28:05 EDT 
Created attachment 130986 [details]
Patch to use "Enter" to simulate a mouse double click for accessibililty

This patch uses the keyboard's "Enter" key to simulate the mouse double click action, i.e. generating a RequestConstants.REQ_OPEN request and send it to the EditPart.performRequest(request) method. 

With this change, the DirectEditSelectionTool will handle more than just direct edit mouse selection. So maybe need to rename it to something like CustomWSDLEditorTool and move it to the design package?
Comment 2 Raymond Lai CLA 2009-04-06 09:38:28 EDT 
Created attachment 130987 [details]
New patch to simulate double click with "Enter" key for accessibility

Should have done a NPE check to ensure the EditPart is not null.
Comment 3 Raymond Lai CLA 2009-04-13 10:57:02 EDT 
Valentin, can you review the patch?
Comment 4 Valentin Baciu CLA 2009-04-15 16:03:17 EDT 
Thank you Raymond, fix committed and released for WTP 3.1 builds > v200904152002 UTC.

Please open an enhancement to track the need to add a new entry (Expand) in the context menu as well.
Comment 5 Raymond Lai CLA 2009-04-20 10:50:20 EDT 
Bug 272908 was opened to track the enhancement: https://bugs.eclipse.org/bugs/show_bug.cgi?id=272908
Comment 6 Raymond Lai CLA 2009-05-04 13:14:21 EDT 
I verified the fix in 3.1M7-20090504062826.
Comment 7 Valentin Baciu CLA 2009-05-04 13:28:41 EDT 
Closing.