Bug 270257 - [perfs] Small regression on 'JDT/Core plugin initialization' test
Summary: [perfs] Small regression on 'JDT/Core plugin initialization' test
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance, test
Depends on:
Blocks:
 
Reported: 2009-03-27 08:31 EDT by Frederic Fusier CLA
Modified: 2009-04-28 09:43 EDT (History)
1 user (show)

See Also:

Attachments
Proposed patch (1.13 KB, patch)
2009-03-27 08:38 EDT, Frederic Fusier CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Fusier CLA 2009-03-27 08:31:03 EDT 
Since build I20090317-1029, I observed a small regression on the FullSourceWorkspaceModelTests#testInitJDTPlugin() test.

Here are the numbers:

SLED 10 Sun 1.5.0_10 (2 x 3.00GHz - 3GB RAM)

M6	I20090313-0100	-0.3%
	N20090314-2000	0.0%
	I20090317-1029	-3.9%
	N20090319-2000	-4.6%
	N20090321-2000	-4.6%
	I20090324-0800	-7.1%
	I20090324-1325	-3.9%
	I20090325-1135	-3.6%

RHEL 5.0 Sun 6.0_04 (2 x 3.00GHz - 3GB RAM)

M6	I20090313-0100	-0.6%
	N20090314-2000	-0.9%
	I20090317-1029	-5.5%
	N20090319-2000	-5.7%
	N20090321-2000	-5.5%
	I20090324-0800	-5.5%
	I20090324-1325	-5.8%
	I20090325-1135	-5.4%
Comment 1 Frederic Fusier CLA 2009-03-27 08:36:54 EDT 
This is a consequence of the fix for bug 269476....

As there's now an additional clean-up of the DeltaProcessingState deltaProcessors local thread while restarting, more is now necessary to garbage memory during the start-up, hence explains the noticed regression.

This concerns only the performance test case. In standard Eclipse usage, this simulateRestart method is never called. So, I will comment the test with this explanation...
Comment 2 Frederic Fusier CLA 2009-03-27 08:38:05 EDT 
Created attachment 130098 [details]
Proposed patch
Comment 3 Frederic Fusier CLA 2009-03-27 08:39:28 EDT 
Released for 3.5M7 in HEAD stream.
Comment 4 David Audel CLA 2009-04-28 09:43:39 EDT 
Verified for 3.5M7