Community
Participate
Working Groups
Build ID: M20090211-1700 Steps To Reproduce: Hi, If I add an extension point I can input a string. This string is automatically considered as a wildcard string. E.g. if I input view I get org.eclipse.views and org.eclipse.viewActions. I would like to have the same behaviour for adding plug-in dependencies. E.g. if I want to add a dependencies to de.vogella.model I currently have to input *model* if I want to search for all plug-ins which contain model. I would consider a similar behaviour as in extension useful. Is it possible to add this? Best regards, Lars
Reasonable request, but we would need a contributed patch for this to happen.
Created attachment 130625 [details] patch-PluginSelectionDialog.txt
Created attachment 130626 [details] patch-abstractElementListSelectionDialog.txt
Hi, patches attached. Please let me know if this approach is not feasible or if I should change anything. To tried to make the changes as minimal as I could. Best regards, Lars
Created attachment 130627 [details] patch-ConditionalListSelectionDialog.txt This patch would create the same behavior (wildcard matching) to the Runtime - Add dialog.
ah, your patch makes things a bit more complicated Lars ;) You're adding API :)
Yes, unfortunately I do. But I don't see how to do it without API changes (or without pulling a lot of duplicate code from AbstractElementListSelectionDialog into the other classes). Any suggestion how to make it without API changes?
One idea is to have PluginSelectionDialog extend from FilteredItemsSelectionDialog and pimp it out. I think FilteredItemsSelectionDialog allows you to do the type of filtering you want.
Created attachment 130634 [details] org.eclipse.pde.ui.patch Here's a quick stab at using FilteredItemSelectionDialog Feel free to hack on it, I have to head to dinner tonight and check out for a bit :)
Lars, with the current patch you'd have to modify PluginSearchItemsFilter to suit your needs.
Thank you Chris, I'll give it a try (unfortunately the next days I most likely will not find the time...)
I actually committed the latest patch Lars. It should be easy to enhance to meet your use case. I actually like the new dialog now ;)
Created attachment 130769 [details] PluginSearchItemsFilter Hi Chris, very nice new dialog. Thank you The attached patch would add * to the beginning of the search string, except in case the first letter is either "*", "." or "?".
done. > 20090403 I made some small fixes and added alphabetical sorting. Thanks Lars.
Looks perfect. Thank you.
Created attachment 130918 [details] PointSelectionPage Chris, I like the behavior of the dependency matching (add "*" if the first character is not a wildcard). Currently the Extension behaves a bit different. It search for a wildcard at any position. I changes this with the attached patch. This way it is easier to search for extenstions, e.g. you could type .ui. to see all extensions which apply to "*.ui.". What do you think? Best regards, Lars
Reopened, in case your are using Mylyn filter to filter out closed bugs. The patch above alines the behavior of the dependency and extension wildcard support.
done. > 20090406 Works for me ;)
