Bug 269503 - Cancel calculating dependencies is unpredictable
Summary: Cancel calculating dependencies is unpredictable
Status: RESOLVED WORKSFORME
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: PC Linux-GTK
: P3 normal with 1 vote (vote)
Target Milestone: 3.5   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on: 216278
Blocks:
  Show dependency tree
 
Reported: 2009-03-20 08:14 EDT by Bernd Oliver Sünderhauf CLA
Modified: 2009-04-13 16:35 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bernd Oliver Sünderhauf CLA 2009-03-20 08:14:23 EDT
Build ID: I20090313-0100

Steps To Reproduce:
1. In the "Install New Software" dialog,
2. check an arbitrary component and click on "Next >". The status says "Calculating requirements and dependencies".
3. Click the "Cancel" button at different points of progress (as seen in the progressmeter)

Up to a progress of ~50%, the current operation is being cancelled, just as expected.

However, from that point on (50%+), the "Cancel button becomes unpredictable: In some cases the whole dialog is being closed. In other cases, clicking the "Cancel" button is ignored and the dialog proceeds to the next step.

More information:
I couldn't come up with an explanation in which cases either of the two unexpected behaviours occurs. However, in my standard Eclipse install, the former happens when checking "PDT SDK Feature", the latter when checking "PDT Runtime feature", which seems a bit mysterious, but might have a reason.
Comment 1 Henrik Lindberg CLA 2009-03-22 14:02:13 EDT
In bug 216278 there is a patch that merges the code for transports. In the merged implementation care has been taken to ensure that the correct monitor is passed around to the communication layer. Not sure this fixes all aspects of the issue reported there, but please try again after the patch in bug 216278 is released.
Comment 2 Pascal Rapicault CLA 2009-03-29 09:29:44 EDT
The difference in behavior could also be explained by having some place in the code not checking for the cancelled exception.
Comment 3 John Arthorne CLA 2009-04-13 16:35:04 EDT
I just tried reproducing in I20090407-1430 and this problem seems to be fixed by the repository merge mentioned in comment #1. Calculating dependencies for either PDT SDK or Runtime feature cancels promptly and the dialog never closes. It is possible that cancelation very close to the end of calculation will not cancel, but this is normal cancel behaviour in Eclipse - if the operation is done or almost done, the cancelation is ignored.

Please reopen if you can reproduce a problem in I20090407-1430 or later.