Bug 269442 - [ftp] FTP connections should use passive mode by default
Summary: [ftp] FTP connections should use passive mode by default
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.1   Edit
Hardware: All All
: P2 enhancement (vote)
Target Milestone: 3.5 RC1   Edit
Assignee: Martin Oberhuber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: noteworthy
: 174772 (view as bug list)
Depends on:
Blocks: 264943 408223
  Show dependency tree
 
Reported: 2009-03-19 15:35 EDT by Martin Oberhuber CLA
Modified: 2013-05-17 15:24 EDT (History)
1 user (show)

See Also:
ddykstal.eclipse: review+

Attachments
Screenshot of Filezilla Client 3.7.0.1 Settings (19.83 KB, image/gif)
2013-05-16 08:56 EDT, Martin Oberhuber CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2009-03-19 15:35:11 EDT 
+++ This bug was initially created as a clone of Bug #264943 +++

FTP requires using passive mode for any client that is behind a NAT, since the externally visible IP address will be different in this case than the one seen on the local host -- see bug 264943 for details.

I can't at the moment see any reason for not enabling passive mode, and in fact all other FTP clients I know do use passive by default, so RSE should use passive mode by default as well.
Comment 1 Martin Oberhuber CLA 2009-06-17 11:25:24 EDT 
Will need to work with the Community on whether we can change the default in 3.1.1
Comment 2 Martin Oberhuber CLA 2010-02-26 19:10:24 EST 
Bulk update of target milestones to 3.2
Comment 3 Martin Oberhuber CLA 2011-05-31 18:02:49 EDT 
Bulk move of deferred feature requests to 3.4
Comment 4 Martin Oberhuber CLA 2013-05-15 17:21:05 EDT 
This is finally implemented for TM 3.5 (Kepler) RC1:

https://git.eclipse.org/c/tm/org.eclipse.tm.git/commit/?id=03f94f01c9181a95562628a88cb1d26c583d46c0

This should be added to the new & noteworthy.
Comment 5 Martin Oberhuber CLA 2013-05-16 06:55:50 EDT 
See also bug 174772 for some history
Comment 6 Martin Oberhuber CLA 2013-05-16 08:53:32 EDT 
*** Bug 174772 has been marked as a duplicate of this bug. ***
Comment 7 Martin Oberhuber CLA 2013-05-16 08:56:12 EDT 
Created attachment 231075 [details]
Screenshot of Filezilla Client 3.7.0.1 Settings

I've checked some other Open Source FTP clients, and found that FileZilla client also uses passive mode by default (and recommends doing so). FileZilla also has some "fallback" mechanisms and recommends using "the other mode" in case passive mode fails. It also keeps a list of "succesful transfers" vs "failed transfers".

I still think we should stick to passive mode as the new default in RSE.

For bug 408223 (and probably other issues we may find during testing) we should look for better error handling.
Comment 8 David Dykstal CLA 2013-05-17 15:24:18 EDT 
I've checked a couple of commercial clients and they default to passive mode as well. This change makes perfect sense.