Community
Participate
Working Groups
In this code: @Aspect public class Logger { @Before("execution(* Other.*())") public void foo() { } } The aspectj handle for method foo looks like this: =Boo/src<h{Logger.java}Logger&foo There are two problems with this. According to the text: 1. Logger is a class, not an aspect 2. foo is a method, not advice So, I would like to see something like this: =Boo/src<h{Logger.java[Logger~foo Would it be possible to generate the handle based on the text, rather than what it represents in the compiler? The same goes for other @Aspect kinds like pointcuts and declare. These kinds of elements should not have any aspecty parts to their handles. It should look like Java handles.
i guess the handle could be based on the declaration, but we'll have to undo some stuff - hopefully the necessary information is around to identify these are annotation style constructs.
*** Bug 270200 has been marked as a duplicate of this bug. ***
I suggest that this bug should be marked as major as it removed functionality that existed in the xref view using previous versions of aspectj. See duplicate bug 270200. The greatly hinders development of @AspectJ sytax aspects.
indeed. shame it wasnt found sooner.
fixed for aspects, advice, decw, dece - that should cover the major issues. Not fixed for pointcuts or declareparents - the former seems to have some kind of other issue internally where the pointcut methods are modified in name by ajc (doesn't seem right) - and no-one can be using @declareparents or we'd have a million reported problems due to it not supporting incremental compilation. I'll address these if they come up, but important that the basics now work. I guess this means the last couple of AJDTs are pretty much useless for annotation style development, including the one in STS. Needs some AJDT tests for anno style I think, given that the only spec the handles must obey for use in AspectJ is that they are a unique identifier for an element in the hierarchy. follow on problems which don't seem so urgent unless i hear otherwise are in bug 270305
Nice moving with this one. Is this already in AJDT?
no - i'm tired of doing aj upgrades in ajdt every few mins :) I'll do one a bit later that will have whatever i've achieved in other bugs too.
