Community
Participate
Working Groups
Created attachment 129226 [details] Screehshot of the preference page in HC mode In the high contrast mode "Available Software Site" preferences page looks very strange: - it takes full screen (it is really large but in normal mode that is not so problematic as in HC mode) - it has icon in the corner that redners as something blue for me - note strange background color for the "Name" column (This dialog is also accessible from "Check for updates" which asks you if you want to select update sites.) To enable high contrast mode: - Open Control pannel - Open Accessibility Options - On the "Display" tab select "Use High Contrast" checkbox
I don't think there's anything particular to our dialog here, but the resizing needs a look. > - it takes full screen (it is really large but in normal mode that is not so > problematic as in HC mode) I think it is a bit wide. More problematic is that the vertical button stack resizes out of view and instead the list should shrink. I will look into that. > - it has icon in the corner that redners as something blue for me I am assuming this would happen on every pref page? I think those are the forward/back and view drop down controls. ie, there is nothing special placed here by the p2 dialog. > - note strange background color for the "Name" column that is the sort indicator shading in the tree (SWT) I will look into the resizing and verify that the pref page controls have the same problem everywhere (in which case I'll open a platform UI bug)
investigate for RC1
I've made changes to the layout so we get a better/smaller initial size that is more consistent with the other p2 dialogs. > > > - it takes full screen (it is really large but in normal mode that is not so > > problematic as in HC mode) > The layout code was using hard-coded (large) dialog-unit widths and heights. In p2 we now have standard constants for default widths and heights so I switched over to these. Much better. > I think it is a bit wide. More problematic is that the vertical button stack > resizes out of view and instead the list should shrink. > I will look into that. Verified that this is standard pref page behavior. At some point (not sure what), the pref page adds a horizontal scroll bar and resizing the pref dialog shrinks the page. You can still get to the content by scrolling. This is set up in the preference dialog and I verified that other pages have the same issue. > > > - it has icon in the corner that redners as something blue for me > I am assuming this would happen on every pref page? I think those are the > forward/back and view drop down controls. ie, there is nothing special placed > here by the p2 dialog. I did not have the problem depicted in your screen shot, but I did check that it's the same controls that every other page uses, so if it looked funny in your setup, it would have been that way everywhere. > > > - note strange background color for the "Name" column > > that is the sort indicator shading in the tree (SWT) Verified that other dialogs that use a column sort indicator look the same.
Created attachment 134648 [details] layout patch this patch changes the default height/width of the repo table to use the p2 constants defined for these. There is also some cleanup done so that GridData is created with the same constructor to make the intentions of the layout clearer.
Patch looks fine and runs fine. (In reply to comment #3) > > > - it has icon in the corner that redners as something blue for me > I did not have the problem depicted in your screen shot Me neither. > > > - note strange background color for the "Name" column > > > > that is the sort indicator shading in the tree (SWT) > > Verified that other dialogs that use a column sort indicator look the same. I'm seeing that too, but I could only fine one other page with a table and there I did not see this odd background (will attach screen shot). Plus, I don't get it with the Problems view.
Created attachment 134711 [details] Keys pref page in HC - no funny background color in sorted column
fixed in HEAD >20090506. > > Verified that other dialogs that use a column sort indicator look the same. > > I'm seeing that too, but I could only fine one other page with a table and > there I did not see this odd background (will attach screen shot). Plus, I > don't get it with the Problems view. > I looked at the Help>About>Plug-in details and saw the problem. Didn't look at the others. Opened bug 275236 for this, to be sorted out later (no pun intended....bigger fish to fry right now).
