Community
Participate
Working Groups
It seems that there are a few small twicks that can be done to improve P2 dialogs accessibility: 1) "Install New Software" dialog: tab ordering: read-only "Details" field is included in the tab order. 2) "Install New Software" dialog: tabbing into the tree of available software does not set visible focus highlight on a tree element 3) "Install New Software" dialog: tree of available software should have a label describing what it is with a keyboard accelerator 4) "Install New Software" dialog: hyperlinks for preferences and "already installed" don't have keyboard accelerators 5) "Install New Software" dialog: "More..." hyperlink appearing in the details for some features needs a keyboard accelerator. (Not accessibility related, but that button is a strange beast. Would it make more sense to have it always displayed and enable/disable?) 6) "Install New Software" dialog -> "Next": The dialog title "Review the items to be installed" is incldued in the tab order 7) "Install New Software" dialog -> "Next": Same thing as above about tree element not being highlighted 8) "Install New Software" dialog -> "Next": Same thing as above about tree needing to have a label 9) "Install New Software" dialog -> "Next": Same things as above about "Details" and "More" buttons 10) "Install New Software" dialog -> "Next" -> "Next": Same things as above for the dialog title, should license text be included in the tab order?, tree control needs label 11) "Install/Update" preference page: duplicate keyboard accelerators for "Ask me what to do" and "Apply" buttons 12) "Automatic updates" preference page: duplicate keyboard accelerators for "Download new updates automatically" and "Apply" buttons
The read only fields included in the tab order are specifically done so for accessibility (screen readers). So I'm not sure that these would be considered accessibility problems. None of the links in Eclipse that I know of have keyboard mnemonics (but they should be tabbable) so I don't think this is an issue. Will fix other problems.
Yes, it would be a problem if those read-only field *weren't* in the tab order.
investigate for RC1
Fixing the duplicate mnemonics, but I don't see anything else we should address. (In reply to comment #0) > It seems that there are a few small twicks that can be done to improve P2 > dialogs accessibility: > > 1) "Install New Software" dialog: tab ordering: read-only "Details" field is > included in the tab order. This is for screen reader support, required for accessibility > > 2) "Install New Software" dialog: tabbing into the tree of available software > does not set visible focus highlight on a tree element After doing some digging, I found that this is bug 148364. I doubt this will ever be fixed and the problem exists across the SDK. If there were a concerted effort in the SDK to avoid the bug, we could do the same. > > 3) "Install New Software" dialog: tree of available software should have a > label describing what it is with a keyboard accelerator This is a filtered tree, and there's no way to insert label text between the filter text and the tree. Note that the preferences dialog and any other filtered tree dialogs have the same issue, so I'm assuming this is acceptable. It is reachable through tabbing. > > 4) "Install New Software" dialog: hyperlinks for preferences and "already > installed" don't have keyboard accelerators None of the hyperlinks in the SDK have mnemonics. They are reachable through tabbing. > > 5) "Install New Software" dialog: "More..." hyperlink appearing in the details > for some features needs a keyboard accelerator. (Not accessibility related, but > that button is a strange beast. Would it make more sense to have it always > displayed and enable/disable?) It is accessible through tabbing. Agree it's a strange beast, see 273513. I added your remark to that bug. > > 6) "Install New Software" dialog -> "Next": The dialog title "Review the items > to be installed" is incldued in the tab order This is intentional so that screen readers can read it > > 7) "Install New Software" dialog -> "Next": Same thing as above about tree > element not being highlighted bug 148364 > > 8) "Install New Software" dialog -> "Next": Same thing as above about tree > needing to have a label There are few wizards that will label the main tree when there is only one main control. Often the wizard description (which is reachable by screen readers) will provide overall context. > > 9) "Install New Software" dialog -> "Next": Same things as above about > "Details" and "More" buttons same response as above > > 10) "Install New Software" dialog -> "Next" -> "Next": Same things as above for > the dialog title, should license text be included in the tab order?, tree > control needs label the license list and license text have a label and both are reachable in the tab order. Note the license list suffers the same focus indicator problem (bug 148364) > > 11) "Install/Update" preference page: duplicate keyboard accelerators for "Ask > me what to do" and "Apply" buttons Fixed. Good catch > > 12) "Automatic updates" preference page: duplicate keyboard accelerators for > "Download new updates automatically" and "Apply" buttons > Fixed. Another good catch.
Created attachment 134548 [details] patch that fixes conflicting mnemonics Kevin, can you please review. Can you also please read my responses to items 1-10 and let me know if you think any of these should be addressed by p2 in the long run. If so, I will open separate bugs for those and address after 3.5. To me, they seem to be things we do all over the place and probably don't need to address unless/until we make some effort across the SDK to fix consistently.
apparently I did not set review flag :(
Reviewed patch. As I commented, strictly speaking it's not necessary that Cancel have a mneumonic since <escape> always triggers it, but then it doesn't hurt to avoid the conflicts, so +1.
Kevin, you commented in bug 269079 and approved this one. Just double checking that you reviewed this one? (The mnemonic conflics in this bug involve the A in &Apply)
(In reply to comment #8) > Kevin, you commented in bug 269079 and approved this one. Just double checking > that you reviewed this one? > > (The mnemonic conflics in this bug involve the A in &Apply) Ah that was the problem! Had both bugs open, picked the wrong one (meant to +1 the other one).
(In reply to comment #4) > > 1) "Install New Software" dialog: tab ordering: read-only "Details" field is > > included in the tab order. > > This is for screen reader support, required for accessibility Yup. Similarly, in wizards you can back-tab to the description text at the top of the wizard. > > 2) "Install New Software" dialog: tabbing into the tree of available software > > does not set visible focus highlight on a tree element > > After doing some digging, I found that this is bug 148364. I doubt this will > ever be fixed and the problem exists across the SDK. If there were a concerted > effort in the SDK to avoid the bug, we could do the same. Wow that's really unfortunate. > > 3) "Install New Software" dialog: tree of available software should have a > > label describing what it is with a keyboard accelerator > > This is a filtered tree, and there's no way to insert label text between the > filter text and the tree. Note that the preferences dialog and any other > filtered tree dialogs have the same issue, so I'm assuming this is acceptable. Yes, I think it's fine as is. If we felt though that it wasn't clear what the contents of the tree was, we could improve the wizard heading message "Check the items that you wish to install" to use something other than "items". > > 4) "Install New Software" dialog: hyperlinks for preferences and "already > > installed" don't have keyboard accelerators > > None of the hyperlinks in the SDK have mnemonics. They are reachable through > tabbing. That's sufficient and consistent. Patch looks fine +1
fixed >20090507.
