Bug 269065 - [TableEditor] Cell editors misaligned when cell padding is set on table
Summary: [TableEditor] Cell editors misaligned when cell padding is set on table
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.2   Edit
Hardware: All All
: P1 normal (vote)
Target Milestone: 1.2 M7   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 273569
Blocks:
  Show dependency tree
 
Reported: 2009-03-17 15:46 EDT by Ralf Sternberg CLA
Modified: 2009-04-24 06:35 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Sternberg CLA 2009-03-17 15:46:46 EDT 
Original reported on bug 262172, comment 13.
Cell editors are offset to the right by the amount of cell padding defined in the theme like this:

Table-Cell {
  padding: 4px;
}

The Table bounds, imageBounds, and textBounds appear to be correct. We need to investigate which data is used by JFace for alignment.
Comment 1 Ralf Sternberg CLA 2009-03-17 15:49:44 EDT 
See attachment 129073 [details] and attachment 129074 [details].
Comment 2 Ralf Sternberg CLA 2009-04-24 06:26:54 EDT 
This problem is caused by the computeBounds method in TableEditor, which relies on the assumption that the itemImageBounds start at the left edge of the itemBounds. This assumption is not true with cell paddings anymore.

Applied the patch attached to SWT bug 273569 to the RWT TableEditor.
Comment 3 Ralf Sternberg CLA 2009-04-24 06:35:25 EDT 
Please note that there is still an issue with Text cell editors. This is caused by bug 264221.