Bug 269007 - [ds tooling]: Cannot unset bind/unbind methods on service references
Summary: [ds tooling]: Cannot unset bind/unbind methods on service references
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2009-03-17 11:14 EDT by Neil Bartlett CLA
Modified: 2009-04-27 09:31 EDT (History)
4 users (show)

See Also:


Attachments
org.eclipse.pde.ds.ui.patch (2.16 KB, patch)
2009-03-18 11:35 EDT, Chris Aniszczyk CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Neil Bartlett CLA 2009-03-17 11:14:41 EDT
(Eclipse 3.5M6 on Mac OSX/Cocoa/x86_64)

When editing a service reference in the DS component editor, it is impossible to remove bind/unbind methods from service reference (at least without going into the XML source).

Add a service reference with a bind method "setFoo" and unbind method "unsetFoo". Then edit the reference and blank out the bind/unbind method names and click Ok. The names will still be setFoo/unsetFoo.
Comment 1 Chris Aniszczyk CLA 2009-03-17 11:23:07 EDT
Ah, the issue is with blanking the names out, go figure.

Thanks for the catch.
Comment 2 Neil Bartlett CLA 2009-03-17 11:25:32 EDT
(In reply to comment #1)
> Ah, the issue is with blanking the names out, go figure.

Oops, yes, typo in my bug title. I means cannot UNset method names. Sorry.
Comment 3 Chris Aniszczyk CLA 2009-03-18 11:35:57 EDT
Created attachment 129234 [details]
org.eclipse.pde.ds.ui.patch

A potential solution.

However, I'm noticing that no matter what I do... unbind never gets blanked out. bind does though... wtf!
Comment 4 Chris Aniszczyk CLA 2009-03-18 11:36:42 EDT
Benjamin, do you have time to look at my issue? I spent about 30 mins spinning my wheels and need another set of eyes.
Comment 5 Benjamin Cabé CLA 2009-03-18 11:37:44 EDT
OK!
Comment 6 Benjamin Cabé CLA 2009-03-18 13:14:38 EDT
I don't have the issue on XP :-(
I really need to buy a Macbook in the first Apple Store I'll find in California :p

I'm sorry but even with some attentive code reading, I don't really know where the problem could be :/
What happens if you swap the order of bind and unbind  commits? (lines 184-201 of DSEditReferenceDialog)
Comment 7 Chris Aniszczyk CLA 2009-03-18 18:19:39 EDT
(In reply to comment #6)
> I don't have the issue on XP :-(
> I really need to buy a Macbook in the first Apple Store I'll find in California
> :p

Oh man, that reminds me of the time the Europeans invaded all the Apple stores last year to get iPhones ;) 
Comment 8 Chris Aniszczyk CLA 2009-04-01 17:48:31 EDT
done.

> 20090401

Thanks for the report Neil.
Comment 9 Stoyan Boshev CLA 2009-04-27 08:21:45 EDT
I was about to report the same bug twice. 
Changing the summary, because it was wrong.

BTW the same applies for the target value. It cannot be unset. I saw it is not fixed with the proposed patch. Shall I open a new bug?
Comment 10 Chris Aniszczyk CLA 2009-04-27 09:31:37 EDT
I quickly fixed the problem in HEAD regarding target.